Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171109014109.21077-1-mike.kravetz@oracle.com>
References: <20171109014109.21077-1-mike.kravetz@oracle.com>
From:   =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Date:   Mon, 20 Nov 2017 11:28:09 +0100
Message-ID: <CAJ+F1CKsehGaan8ZgSNEBQ6sveyMVYH5Wr4ggys-czpmbV8Qvg@mail.gmail.com>
Subject: Re: [RFC PATCH 0/3] restructure memfd code
To:     Mike Kravetz <mike.kravetz@oracle.com>
Cc:     linux-mm@kvack.org, open list <linux-kernel@vger.kernel.org>,
        Hugh Dickins <hughd@google.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Michal Hocko <mhocko@kernel.org>,
        David Herrmann <dh.herrmann@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi

On Thu, Nov 9, 2017 at 2:41 AM, Mike Kravetz <mike.kravetz@oracle.com> wrot=
e:
> With the addition of memfd hugetlbfs support, we now have the situation
> where memfd depends on TMPFS -or- HUGETLBFS.  Previously, memfd was only
> supported on tmpfs, so it made sense that the code resides in shmem.c.
>
> This patch series moves the memfd code to separate files (memfd.c and
> memfd.h).  It creates a new config option MEMFD_CREATE that is defined
> if either TMPFS or HUGETLBFS is defined.

That looks good to me

>
> In the current code, memfd is only functional if TMPFS is defined.  If
> HUGETLFS is defined and TMPFS is not defined, then memfd functionality
> will not be available for hugetlbfs.  This does not cause BUGs, just a
> potential lack of desired functionality.
>

Indeed

> Another way to approach this issue would be to simply make HUGETLBFS
> depend on TMPFS.
>
> This patch series is built on top of the Marc-Andr=C3=A9 Lureau v3 series
> "memfd: add sealing to hugetlb-backed memory":
> http://lkml.kernel.org/r/20171107122800.25517-1-marcandre.lureau@redhat.c=
om

Are you waiting for this series to be merged before resending as non-rfc?

>
> Mike Kravetz (3):
>   mm: hugetlbfs: move HUGETLBFS_I outside #ifdef CONFIG_HUGETLBFS
>   mm: memfd: split out memfd for use by multiple filesystems
>   mm: memfd: remove memfd code from shmem files and use new memfd files
>
>  fs/Kconfig               |   3 +
>  fs/fcntl.c               |   2 +-
>  include/linux/hugetlb.h  |  27 ++--
>  include/linux/memfd.h    |  16 +++
>  include/linux/shmem_fs.h |  13 --
>  mm/Makefile              |   1 +
>  mm/memfd.c               | 341 +++++++++++++++++++++++++++++++++++++++++=
++++++
>  mm/shmem.c               | 323 -----------------------------------------=
---
>  8 files changed, 378 insertions(+), 348 deletions(-)
>  create mode 100644 include/linux/memfd.h
>  create mode 100644 mm/memfd.c
>
> --
> 2.13.6
>

Thanks

--=20
Marc-Andr=C3=A9 Lureau

From 1583550835120240448@xxx Thu Nov 09 01:42:40 +0000 2017
X-GM-THRID: 1583550835120240448
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread