Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=iso-8859-2
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: [PATCH v3 5/5] misc serdev: w2sg0004: add debugging code and Kconfig
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <20171115164257.2mbbk7yqhq3puc5a@lenoch>
Date:   Wed, 15 Nov 2017 18:13:51 +0100
Cc:     =?iso-8859-2?Q?Andreas_F=E4rber?= <afaerber@suse.de>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        =?iso-8859-2?Q?Beno=EEt_Cousson?= <bcousson@baylibre.com>,
        Tony Lindgren <tony@atomide.com>,
        Russell King <linux@armlinux.org.uk>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Thierry Reding <treding@nvidia.com>,
        Jonathan Cameron <jic23@kernel.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org, letux-kernel@openphoenux.org,
        kernel@pyra-handheld.com, linux-arm-kernel@lists.infradead.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <2CFA9F17-0E65-4804-9971-922500F5E919@goldelico.com>
References: <cover.1510759152.git.hns@goldelico.com> <9b4969c858d4c3801bb796f92dad5c580799b768.1510759152.git.hns@goldelico.com> <28e16c7a-2688-a302-1548-1cdc2552f0ad@suse.de> <DC57A290-669C-4B3C-A4EE-2ABEA37F47CE@goldelico.com> <20171115164257.2mbbk7yqhq3puc5a@lenoch>
To:     Ladislav Michl <ladis@linux-mips.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Ladislav,

> Am 15.11.2017 um 17:42 schrieb Ladislav Michl <ladis@linux-mips.org>:
>=20
> On Wed, Nov 15, 2017 at 05:29:25PM +0100, H. Nikolaus Schaller wrote:
>> Hi Andreas,
>>=20
>>> Am 15.11.2017 um 16:53 schrieb Andreas F=E4rber <afaerber@suse.de>:
>>>=20
>>> Hi,
>>>=20
>>> Am 15.11.2017 um 16:19 schrieb H. Nikolaus Schaller:
>>>> This allows to set CONFIG_W2SG0004_DEBUG which will
>>>> make the driver report more activities and it will turn on the
>>>> GPS module during boot while the driver assumes that it
>>>> is off. This can be used to debug the correct functioning of
>>>> the hardware. Therefore we add it as an option to the driver
>>>> because we think it is of general use (and a little tricky to
>>>> add by system testers).
>>>>=20
>>>> Normally it should be off.
>>>> ---
>>>=20
>>> If you want to merge this, it is lacking a Sob.
>>=20
>> Whats is a "Sob" in this context =
(https://acronyms.thefreedictionary.com/SOB)?
>=20
> https://acronyms.thefreedictionary.com/Signed-Off-By

Ah, ok. Too obvious to associate :) Tnx.

I did never think about that this could be missing. And I don't know why =
:(

> Also please read Documentation/process/submitting-patches.rst

We have automated things by calling checkpatch but it somwhow failed =
here.

BR and thanks,
Nikolaus


From 1584153060362365990@xxx Wed Nov 15 17:14:46 +0000 2017
X-GM-THRID: 1584152532229484824
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread