Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] cpupowerutils: bench - Fix cpu online check
To:     Shuah Khan <shuahkh@osg.samsung.com>,
        Shuah Khan <shuah@kernel.org>,
        Thomas Renninger <trenn@suse.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20171107094755.49440-1-huntbag@linux.vnet.ibm.com>
From:   Abhishek <huntbag@linux.vnet.ibm.com>
Date:   Tue, 7 Nov 2017 15:20:29 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171107094755.49440-1-huntbag@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Message-Id: <3a6fd547-b367-6e35-7fb5-5ab8d1139b5b@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

Can you please have a look at this also?

Thanks and Regards,
Abhishek Goel
System Engineer
IBM India Pvt. Ltd.

On 11/07/2017 03:17 PM, Abhishek Goel wrote:
> cpupower_is_cpu_online was incorrectly checking for 0. This patch fixes
> this by checking for 1 when the cpu is online.
>
> Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
> ---
> v2: Commit message rephrased.
> ---
>   tools/power/cpupower/bench/system.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c
> index c25a74a..2bb3eef 100644
> --- a/tools/power/cpupower/bench/system.c
> +++ b/tools/power/cpupower/bench/system.c
> @@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu)
>
>   	dprintf("set %s as cpufreq governor\n", governor);
>
> -	if (cpupower_is_cpu_online(cpu) != 0) {
> +	if (cpupower_is_cpu_online(cpu) != 1) {
>   		perror("cpufreq_cpu_exists");
>   		fprintf(stderr, "error: cpu %u does not exist\n", cpu);
>   		return -1;


From 1583408467635273168@xxx Tue Nov 07 11:59:47 +0000 2017
X-GM-THRID: 1583408467635273168
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread