Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 15 Nov 2017 10:08:13 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Ben Hutchings <ben@decadent.org.uk>
Cc:     linux-kernel@vger.kernel.org, Sachin Prabhu <sprabhu@redhat.com>,
        stable@vger.kernel.org, Pavel Shilovsky <pshilov@microsoft.com>
Subject: Re: [PATCH 3.18 36/68] Handle mismatched open calls
Message-ID: <20171115090813.GB25434@kroah.com>
References: <20170505183212.587141964@linuxfoundation.org>
 <20170505183214.050929158@linuxfoundation.org>
 <1500050552.2707.145.camel@decadent.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1500050552.2707.145.camel@decadent.org.uk>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 14, 2017 at 05:42:32PM +0100, Ben Hutchings wrote:
> On Fri, 2017-05-05 at 11:32 -0700, Greg Kroah-Hartman wrote:
> > 3.18-stable review patch.��If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Sachin Prabhu <sprabhu@redhat.com>
> > 
> > commit 38bd49064a1ecb67baad33598e3d824448ab11ec upstream.
> [...]
> > --- a/fs/cifs/smb2ops.c
> > +++ b/fs/cifs/smb2ops.c
> > @@ -1461,6 +1461,8 @@ struct smb_version_operations smb21_oper
> > �	.clear_stats = smb2_clear_stats,
> > �	.print_stats = smb2_print_stats,
> > �	.is_oplock_break = smb2_is_valid_oplock_break,
> > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> > �	.downgrade_oplock = smb2_downgrade_oplock,
> > �	.need_neg = smb2_need_neg,
> > �	.negotiate = smb2_negotiate,
> > @@ -1542,6 +1544,8 @@ struct smb_version_operations smb30_oper
> > �	.print_stats = smb2_print_stats,
> > �	.dump_share_caps = smb2_dump_share_caps,
> > �	.is_oplock_break = smb2_is_valid_oplock_break,
> > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> > +	.handle_cancelled_mid = smb2_handle_cancelled_mid,
> > �	.downgrade_oplock = smb2_downgrade_oplock,
> > �	.need_neg = smb2_need_neg,
> > �	.negotiate = smb2_negotiate,
> [...]
> 
> This doesn't look right.  handle_cancelled_mid should be initialised
> once in each of the 3 smb_version_operations structures, shouldn't it?

Yeah, something is odd with this, I'll look into it later today, thanks
for flagging it.

greg k-h

From 1573628596378860071@xxx Sat Jul 22 13:12:55 +0000 2017
X-GM-THRID: 1572917095851905670
X-Gmail-Labels: Inbox,Category Forums