Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: comedi: ni_atmio: Handle return value of pnp_*
To:     Ian Abbott <abbotti@mev.co.uk>, hsweeten@visionengravers.com,
        gregkh@linuxfoundation.org
References: <35855327607952b24d97e7f7374a1115f400dd8c.1510806666.git.arvind.yadav.cs@gmail.com>
 <e46b595d-b1f0-617e-d755-7a3cc84ab107@mev.co.uk>
Cc:     linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
From:   arvindY <arvind.yadav.cs@gmail.com>
Message-ID: <5A0E8357.3070306@gmail.com>
Date:   Fri, 17 Nov 2017 12:06:07 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <e46b595d-b1f0-617e-d755-7a3cc84ab107@mev.co.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

hi,

On Thursday 16 November 2017 07:27 PM, Ian Abbott wrote:
> On 16/11/17 04:32, Arvind Yadav wrote:
>> pnp_irq() and pnp_port_start() can fail here and we must check
>> its return value.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>>   drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
>> b/drivers/staging/comedi/drivers/ni_atmio.c
>> index 2d62a8c..dead159 100644
>> --- a/drivers/staging/comedi/drivers/ni_atmio.c
>> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
>> @@ -308,6 +308,9 @@ static int ni_atmio_attach(struct comedi_device 
>> *dev,
>>             iobase = pnp_port_start(isapnp_dev, 0);
>>           irq = pnp_irq(isapnp_dev, 0);
>> +        if (irq == -1 || !iobase)
>> +            return -ENOMEM;
>> +
>>           comedi_set_hw_dev(dev, &isapnp_dev->dev);
>>       }
>>
>
> Can they fail here?  ni_isapnp_find_board() has already checked they 
> are valid.
Yes, you are right. It will not fail.

~arvind


From 1584239579366473354@xxx Thu Nov 16 16:09:57 +0000 2017
X-GM-THRID: 1584195855030414163
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread