Received: by 10.223.164.202 with SMTP id h10csp412234wrb; Wed, 15 Nov 2017 01:43:25 -0800 (PST) X-Google-Smtp-Source: AGs4zMYEdyThwfJM0dkkh8AZpUusKeZbh3DA/Cb9+jgDrCffPw3Pz4oCEaSLuTLajQE5jaPlx/fv X-Received: by 10.99.164.81 with SMTP id c17mr2486975pgp.206.1510739005110; Wed, 15 Nov 2017 01:43:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510739005; cv=none; d=google.com; s=arc-20160816; b=C+0Emd3lAHjfjKeL+eEcBV3rh1x3wGBIS9fZactpuljydB6o1pdxY5uW/FAqBehyrQ TZd3LCQA0VStLb+DYBrv+X/WyVxnUSUg0VXUopIR/1alzEQ2/7eWavXcT2c6//a0w5Ke TyCi7SQo/tGN2wkX7Y1GnR10iDpmRiF8RHZqZFn+JrmkhQL4Ogk9LDRF2HEpweyPNa6j 8zNVf6jz+AP/SAJKZIr/GQZdhQ1xXH626DOud7caEoEqWcVhgzQfiWaBFjUxw4Ho0B9h Lw2UauxuMWRYGRyBVh8KhfhamcGky9t5yBEq8de/U0Z/k7Q0CcvUjbJbJ1A+5avV3XmJ mYmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=h8JZ59Sf9luZim5vGtj8c1qq1DrSeQk7ASE7az6hDlc=; b=rwBWWBXWImlm6Z52hJJqHJrGQLECzgtZIPaWIYcyFSgMfuULLwQExaN00qmPF1kitH 1wZzdG48zOxNSJyvJK/97AV0FQHgv3gc0sSO3Ne3yTbE22jVX8GQkwX7Os+E6B20Sdv/ 87SWizZ5XghHEZ19Hu2w8XHbiQP/OzfBRlqjKMOthg9OjIvBPT3uA/RKSwHvBAescsCK MxJJM9g9u3/Lw+TfBmDJOlmdUXjtIHM/UGw6YHBPD4N40JhHcC2NGZEA5hCLnTMPrU7z SBrLT8K5j0eW6luSlHhH29XuXVXs1CYaM79jnqc7rGOKhiwoqtg4OjfaR+SyLX68G6Ww ebbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=MUZZ8PAm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1si3478558pld.460.2017.11.15.01.43.12; Wed, 15 Nov 2017 01:43:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=MUZZ8PAm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756897AbdKOIMF (ORCPT + 88 others); Wed, 15 Nov 2017 03:12:05 -0500 Received: from mail-yw0-f194.google.com ([209.85.161.194]:45877 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754719AbdKOIL7 (ORCPT ); Wed, 15 Nov 2017 03:11:59 -0500 Received: by mail-yw0-f194.google.com with SMTP id p74so5409303ywe.2 for ; Wed, 15 Nov 2017 00:11:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=h8JZ59Sf9luZim5vGtj8c1qq1DrSeQk7ASE7az6hDlc=; b=MUZZ8PAmfD/q3XN8aCn8edpGa59FE4svj4Big0rpDflcf7uhYV1i6xSmZx6aFUK1pS Gqldve3DLf+D7t5a/pmvG5Sd/mqgOImvAJJ65PqxwZTuTRBxLP5Bup5bhttFYlodicWJ leaqvEPdYXEfWwxsLB4dAqjII7AALUzKGFXpo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=h8JZ59Sf9luZim5vGtj8c1qq1DrSeQk7ASE7az6hDlc=; b=HL4Spsw4oJVULHUXx5Bq/1B1bQCtJEaUg/mHsiaW9+CUDXT8LmdHNp8jreDKGzqyu7 m2FAjMA7NfpfB6ymONUUfsNtunnRlzikOT1NZ9jERTDEUk2yM0gAFZh/qU6dgWI5TlQ3 PHpl+4vADR5KynndfQdXLXrIywCnFaYlGf/oCJE5oybMlvUDvhxq75E+b0V3n1+wMdch Z+OAGJ4DQfMYMeKprtdnBtlf/9HDErXJKx861D586f2DeOwNIF39bcasFW/A0EfejKzt 19g+mk5G7Mr7ohohGGGjPB4ytKBl9GKoe0Nq/cCD+t3nzodZkN+3CJHBfoo0ZDr5OGeu +XcQ== X-Gm-Message-State: AJaThX6F2+4BJWHHVsdDixroPUdwqPLcrYsQQQgl7q24YcDLd4VC1Kv0 2bMo6+Ap7yYIWTR4RsvRcYNzO91XnJU= X-Received: by 10.37.77.10 with SMTP id a10mr9171743ybb.404.1510733518127; Wed, 15 Nov 2017 00:11:58 -0800 (PST) Received: from mail-yw0-f171.google.com (mail-yw0-f171.google.com. [209.85.161.171]) by smtp.gmail.com with ESMTPSA id e124sm2547678ywc.100.2017.11.15.00.11.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Nov 2017 00:11:57 -0800 (PST) Received: by mail-yw0-f171.google.com with SMTP id p74so5409278ywe.2 for ; Wed, 15 Nov 2017 00:11:57 -0800 (PST) X-Received: by 10.37.116.130 with SMTP id p124mr2312001ybc.286.1510733023449; Wed, 15 Nov 2017 00:03:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.80.66 with HTTP; Wed, 15 Nov 2017 00:03:23 -0800 (PST) In-Reply-To: <20171115072927.29367-1-jacob-chen@iotwrt.com> References: <20171115072927.29367-1-jacob-chen@iotwrt.com> From: Tomasz Figa Date: Wed, 15 Nov 2017 16:03:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 0/5] Rockchip ISP1 Driver To: Jacob Chen Cc: "open list:ARM/Rockchip SoC..." , Linux Media Mailing List , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Heiko_St=C3=BCbner?= , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , nicolas@ndufresne.ca, Sakari Ailus , Shunqian Zheng , =?UTF-8?B?6ZKf5Lul5bSH?= , Eddie Cai , Jeffy , Allon Huang , Philipp Zabel , slongerbeam@gmail.com, linux@armlinux.org.uk Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacob, Thanks for sending the series! On Wed, Nov 15, 2017 at 3:29 PM, Jacob Chen wrote: > This patch series add a ISP(Camera) v4l2 driver for rockchip rk3288/rk3399 SoC. > > TODO: > - Thomas is rewriting the binding code between isp, phy, sensors, i hope we could get suggestions. > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/768633/2 > rules: > - There are many mipi interfaces("rx0", "dxrx0")(actually it also could be parallel interface) in SoC and isp can decide which one will be used. > - Sometimes there will be more than one senor in a mipi phy, the sofrware should decide which one is used(media link). > - rk3399 have two isp. Also the two ISP subsystems have their own, completely different, CSI2 PHY blocks, so we need to make the ISP driver work with two different PHY drivers. > - Add a dummy buffer(dma_alloc_coherent) so drvier won't hold buffer. > - Finish all TODO comments(mostly about hardware) in driver. > > To help do a quick review, i have push source code to my Github. > https://github.com/wzyy2/linux/tree/rkisp1/drivers/media/platform/rockchip/isp1 > > Below are some infomations about driver/hardware: > > Rockchip ISP1 have many Hardware Blocks(simplied): > > MIPI --> ISP --> DCrop(Mainpath) --> RSZ(Mainpath) --> DMA(Mainpath) > DMA-Input --> --> DCrop(Selfpath) --> RSZ(Selfpath) --> DMA(Selfpath);) > > (Acutally the TRM(rk3288, isp) could be found online...... which contains a more detailed block diagrams ;-P) > > The funcitons of each hardware block: > > Mainpath : up to 4k resolution, support raw/yuv format > Selfpath : up tp 1080p, support rotate, support rgb/yuv format > RSZ: scaling > DCrop: crop > ISP: 3A, Color processing, Crop > MIPI: MIPI Camera interface > > Media pipelines: > > Mainpath, Selfpath <-- ISP subdev <-- MIPI <-- Sensor > 3A stats <-- <-- 3A parms > > Code struct: > > capture.c : Mainpath, Selfpath, RSZ, DCROP : capture device. > rkisp1.c : ISP : v4l2 sub-device. > isp_params.c : 3A parms : output device. > isp_stats.c : 3A stats : capture device. > mipi_dphy_sy.c : MIPI : sperated v4l2 sub-device. > > Usage: > ChromiumOS: > use below v4l2-ctl command to capture frames. > > v4l2-ctl --verbose -d /dev/video4 --stream-mmap=2 > --stream-to=/tmp/stream.out --stream-count=60 --stream-poll > > use below command to playback the video on your PC. > > mplayer /tmp/stream.out -loop 0 --demuxer=rawvideo > --rawvideo=w=800:h=600:size=$((800*600*2)):format=yuy2 > or > mplayer ./stream.out -loop 0 -demuxer rawvideo -rawvideo > w=800:h=600:size=$((800*600*2)):format=yuy2 > > Linux: > use rkcamsrc gstreamer plugin(just a modified v4l2src) to preview. > > gst-launch-1.0 rkcamsrc device=/dev/video0 io-mode=4 disable-3A=true > videoconvert ! video/x-raw,format=NV12,width=640,height=480 ! kmssink Is the rkcamsrc plugin source available somewhere to download? Thanks, Tomasz From 1584119114847659121@xxx Wed Nov 15 08:15:13 +0000 2017 X-GM-THRID: 1584119114847659121 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread