Received: by 10.223.164.202 with SMTP id h10csp479257wrb; Tue, 14 Nov 2017 04:49:13 -0800 (PST) X-Google-Smtp-Source: AGs4zMbE5wCRUrr2wJU1yxd21JkjxIMfxkrKFIM/LbKIEDfZsPhhgtd7XgW3fEIueLHR96xB22y5 X-Received: by 10.99.126.78 with SMTP id o14mr12088972pgn.159.1510663753258; Tue, 14 Nov 2017 04:49:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510663753; cv=none; d=google.com; s=arc-20160816; b=fzyLs3VC2KTyW8iIW1G/i1eanTN4bk5WZjo9mbTffgTL67+XcbZ3D5vVj94WRUO+yc egxIP5fi9BeEa+MirzxU3zcvaF9vpIML/OwE+i288XfQATJoZB0HWuMTcePzKEjGZfAL /a3Gl8zpq3MC8pWHa+6QufZB9wTLiGpT3JLwTx8zr0W3Om08Nn0OTrEUrg7z07rZwJVq 6Eqs3h6AaW40w2Qt+b+R3sd+GdLNsat2oHC7eqgKgFzU8avDFDfSScTpnS+PHTcCdG9w yHxhBmRKKcDKYMM5lFIpuzue2aseoxLzfnf5tAxUrlyulOuOAWoMhVDSL5GHcEHl4eu8 ZJjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:date:references:in-reply-to:cc:to:from:subject :arc-authentication-results; bh=Ze3sB8Y9IDo4Q4D9STNYtPklnzbvyYr2cR0x4eUIaoI=; b=Ng18TTOWpjlLeO+dvtds5W67PIAwgAXCTWe5o5Z6Lw/zL80wOvNKPj32W608DjyT3q z5B0fpgFiyJGSo3+dgkZUgAd2nRqmmS/GkyBDKOQT+yoT1nl0zMIXZO5MWaRl2W+Zbs2 lefui0P3z1wxo7jBisXvpYCadAFXITyrXQGT2xtO89a/SeY7WeXgXmRS0UEpD4k1UEps x7Jq4bNg2FIKkySWMlcMV5+9A1L5JNpL5K7jd/GXGzkOYch5KHNE2nUjcapFYP6WWJs0 Q+23I2bnmDUZZLc/Ja1YkCFVycVZiFIMwXtOvMfQHe1uEE1u6HKeLcR8Te9bZH7Rtso4 4NMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e22si15414002pgn.671.2017.11.14.04.49.01; Tue, 14 Nov 2017 04:49:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753776AbdKNMsF (ORCPT + 88 others); Tue, 14 Nov 2017 07:48:05 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45196 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754360AbdKNMr5 (ORCPT ); Tue, 14 Nov 2017 07:47:57 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vAEChv79048729 for ; Tue, 14 Nov 2017 07:47:57 -0500 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0a-001b2d01.pphosted.com with ESMTP id 2e7ympkt13-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 14 Nov 2017 07:47:56 -0500 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Nov 2017 07:47:56 -0500 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 14 Nov 2017 07:47:54 -0500 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id vAEClsZ950004086; Tue, 14 Nov 2017 12:47:54 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6606D28041; Tue, 14 Nov 2017 07:47:46 -0500 (EST) Received: from satheesh-thinkpad-t450.in.ibm.com (unknown [9.193.110.44]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP id BC6CA2803D; Tue, 14 Nov 2017 07:47:43 -0500 (EST) Subject: Re: [PATCH v3 2/2] perf/bench/numa: Handle discontiguous/sparse numa nodes From: Satheesh Rajendran To: "Naveen N. Rao" Cc: acme@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, srikar@linux.vnet.ibm.com, bala24@linux.vnet.ibm.com In-Reply-To: <20171031151658.clq6qmdfw3gj6afg@naverao1-tp.localdomain> References: <67b88aa2de6dd199d57bacdecf35d26958780feb.1503310062.git.sathnaga@linux.vnet.ibm.com> <20171031151658.clq6qmdfw3gj6afg@naverao1-tp.localdomain> Content-Type: text/plain; charset="UTF-8" Date: Tue, 14 Nov 2017 18:16:02 +0530 Mime-Version: 1.0 X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 17111412-0024-0000-0000-000002F27E4D X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008065; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000240; SDB=6.00945732; UDB=6.00477315; IPR=6.00726029; BA=6.00005689; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018010; XFM=3.00000015; UTC=2017-11-14 12:47:56 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17111412-0025-0000-0000-000046073CC6 Message-Id: <1510663562.24275.38.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-14_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711140175 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Naveen, On Tue, 2017-10-31 at 20:46 +0530, Naveen N. Rao wrote: >  > >   } > >   BUG_ON(nr_min > nr_max); > > - > Looks like an un-necessary change there. > > - Naveen > I had hit with this compilation error, so had to move the initialization above. Please advice. Thanks.   CC       bench/numa.o bench/numa.c: In function ‘calc_convergence’: bench/numa.c:1035:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]    int processes = count_node_processes(node);    ^ cc1: all warnings being treated as errors mv: cannot stat ‘bench/.numa.o.tmp’: No such file or directory make[4]: *** [bench/numa.o] Error 1 make[3]: *** [bench] Error 2 make[2]: *** [perf-in.o] Error 2 make[1]: *** [sub-make] Error 2 make: *** [all] Error 2 Regards, -Satheesh. > > > >   BUG_ON(sum > g->p.nr_tasks); > > > >   if (0 && (sum < g->p.nr_tasks)) @@ -1027,8 +1029,9 @@ static void calc_convergence(double From 1582787487178857466@xxx Tue Oct 31 15:29:34 +0000 2017 X-GM-THRID: 1576332437617451512 X-Gmail-Labels: Inbox,Category Forums