Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] lost path_put in perf_fill_ns_link_info
To:     linux-kernel@vger.kernel.org,
        Hari Bathini <hbathini@linux.vnet.ibm.com>
Cc:     Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>
References: <c15b71b7-b835-bb48-d459-e553217a003d@virtuozzo.com>
From:   Vasily Averin <vvs@virtuozzo.com>
Message-ID: <d2acbba4-4508-f304-2101-dbfe3f0a9f55@virtuozzo.com>
Date:   Mon, 6 Nov 2017 09:34:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <c15b71b7-b835-bb48-d459-e553217a003d@virtuozzo.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Dear Hari,
I did not found where your patch decreases mnt counter,
it seems for me you have lost path_put in perf_fill_ns_link_info().

Thank you,
	Vasily Averin

On 2017-11-06 09:22, Vasily Averin wrote:
> Fixes: commit e422267322cd ("perf: Add PERF_RECORD_NAMESPACES to include namespaces related info")
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
> ---
>  kernel/events/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 10cdb9c..ab5ac84 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6756,6 +6756,7 @@ static void perf_fill_ns_link_info(struct perf_ns_link_info *ns_link_info,
>  		ns_inode = ns_path.dentry->d_inode;
>  		ns_link_info->dev = new_encode_dev(ns_inode->i_sb->s_dev);
>  		ns_link_info->ino = ns_inode->i_ino;
> +		path_put(&ns_path);
>  	}
>  }
>  
> 

From 1583296720926435526@xxx Mon Nov 06 06:23:37 +0000 2017
X-GM-THRID: 1583296720926435526
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread