Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: tipc_udp_send_msg oops in 4.4 when setting link tolerance
To:     Jon Maloy <jon.maloy@ericsson.com>,
        Ying Xue <ying.xue@windriver.com>,
        "David S. Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "tipc-discussion@lists.sourceforge.net" 
        <tipc-discussion@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <dafc25e8-2a6e-2a0c-c675-de6cf08aa907@nokia.com>
 <AM4PR07MB1714F1520614415FEB38C60D9A2B0@AM4PR07MB1714.eurprd07.prod.outlook.com>
 <ee294a8c-f26c-b50d-3c59-dcc63be958a2@nokia.com>
 <AM4PR07MB1714EFBEC137F93E0562574F9A280@AM4PR07MB1714.eurprd07.prod.outlook.com>
From:   Tommi Rantala <tommi.t.rantala@nokia.com>
Message-ID: <5140a467-3493-752b-b7ba-a9e4c103f21d@nokia.com>
Date:   Wed, 15 Nov 2017 11:42:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <AM4PR07MB1714EFBEC137F93E0562574F9A280@AM4PR07MB1714.eurprd07.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: nokia.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2017 09:42:21.1776 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a3d8a0f-d45e-42e8-beb8-08d52c0d2bbb
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR07MB1314
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14.11.2017 13:35, Jon Maloy wrote:
>> Found it, the missing patch is this one (9b3009604b8e does not help):
>>
>> commit d01332f1acacc0cb43a61f4244dd2b846d4cd585
>> Author: Richard Alpe <richard.alpe@ericsson.com>
>> Date:   Mon Feb 1 08:19:56 2016 +0100
>>
>>       tipc: fix link attribute propagation bug
>>
>>
>> It does not apply as-is to 4.4, so backported it, see below.
>> Does it look good? I can send it forward to Greg for inclusion in 4.4.
> 
> Yes. I would be very grateful if you do.

OK, sent the patch to stable@vger.kernel.org

>> But with this patch included, I can easily reproduce the "BUG: Bad page state
>> in process git" issue also in 4.4 like this:
>>
>> $ tipc link set tolerance 100 link $LINKNAME $ cd /tmp && git clone
>> /path/to/linux-stable
>>
>> I can try to debug that a bit more to see if I can figure it out.
> 
> I would appreciate that. If this turns out to also be an already fixed bug (most likely) you can send that directly to GKH too.
> If you find a bug that requires a new patch send it to tipc-discussion for review first.
> 
> Finally, I want to say that I very much appreciate users like you, who try solving the problems themselves and contribute to the code.
> We are right now in an upgrade phase of TIPC, where we have been/are adding new features to TIPC (overlapping ring neighbor monitoring, group communication, new addressing model, performance improvements...) which inevitably entail some new bugs, but I expect the frequency of these changes/improvements to TIPC go down in a few months, and with that the number of fixes needed.

Thanks!

After more testing, I noticed that I could only reproduce the "BUG: Bad 
page state" in a single machine, so maybe something wrong with the 
machine, and not with tipc.

-Tommi

From 1584041835999256529@xxx Tue Nov 14 11:46:55 +0000 2017
X-GM-THRID: 1583968678491780879
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread