Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 15 Nov 2017 11:12:51 +0000
From:   Russell King - ARM Linux <linux@armlinux.org.uk>
To:     Maciej Purski <m.purski@samsung.com>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] component: add debugfs support
Message-ID: <20171115111250.GC31757@n2100.armlinux.org.uk>
References: <CGME20171115110441eucas1p2555810a1e10e270fd944c2c031d92305@eucas1p2.samsung.com>
 <1510743866-21636-1-git-send-email-m.purski@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1510743866-21636-1-git-send-email-m.purski@samsung.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 15, 2017 at 12:04:26PM +0100, Maciej Purski wrote:
> +static void component_master_debugfs_add(struct master *m);
> +static void component_master_debugfs_del(struct master *m);

Please avoid forward declarations.

> +static int component_devices_show(struct seq_file *s, void *data)
> +{
> +	struct master *m = s->private;
> +	struct component_match *match = m->match;
> +	size_t i;
> +
> +	mutex_lock(&component_mutex);
> +	seq_puts(s, "master name                                            status\n");

Would:

	seq_printf(s, "%-40s %20s\n", "master name", "status");

be better - it becomes more obvious what is intended (that is for the
headings to line up with the data below.)

> +	seq_puts(s, "-------------------------------------------------------------\n");
> +	seq_printf(s, "%-40s %20s\n\n",
> +		   dev_name(m->dev), m->bound ? "bound" : "not bound");
> +
> +	seq_puts(s, "device name                                            status\n");

Ditto.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

From 1584073542829710814@xxx Tue Nov 14 20:10:53 +0000 2017
X-GM-THRID: 1584073542829710814
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread