Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] MIPS: ath25: Avoid undefined early_serial_setup() without
 SERIAL_8250_CONSOLE
To:     Ralf Baechle <ralf@linux-mips.org>
CC:     James Hogan <james.hogan@mips.com>, <linux-mips@linux-mips.org>,
        <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <1510666157-27252-1-git-send-email-matt.redfearn@mips.com>
 <20171114140534.GA14698@linux-mips.org>
From:   Matt Redfearn <matt.redfearn@mips.com>
Message-ID: <c3c985db-3ad7-d5f3-8d3a-065a458b6900@mips.com>
Date:   Tue, 14 Nov 2017 15:43:43 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171114140534.GA14698@linux-mips.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 14/11/17 14:05, Ralf Baechle wrote:
> On Tue, Nov 14, 2017 at 01:29:17PM +0000, Matt Redfearn wrote:
> 
>> Currently MIPS allnoconfig with CONFIG_ATH25=y fails to link due to
>> missing support for early_serial_setup():
>>
>>    LD      vmlinux
>> arch/mips/ath25/devices.o: In function ath25_serial_setup':
>> devices.c:(.init.text+0x68): undefined reference to 'early_serial_setup'
>>
>> Rather than adding dependencies to the platform to force inclusion of
>> SERIAL_8250_CONSOLE together with it's dependencies like TTY, HAS_IOMEM,
>> etc, just make ath25_serial_setup() a no-op when the dependency is not
>> selected in the kernel config.
> 
> Looks like arch/mips/rb532/serial.c might be suffering from the same
> issue?

Hi Ralf!

Indeed it does, and another unmet dependency. Patches incoming.

Thanks,
Matt

> 
>    Ralf
> 

From 1584056534540202757@xxx Tue Nov 14 15:40:32 +0000 2017
X-GM-THRID: 1584048570510523799
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread