Received: by 10.223.164.202 with SMTP id h10csp483715wrb; Tue, 14 Nov 2017 04:53:49 -0800 (PST) X-Google-Smtp-Source: AGs4zMZCp8+MrcY4MI8yn69WguycBEu/Xu22u5zZak2zT3Ta7ahjkwSg+S0960ii+qVVw6p9Gbd/ X-Received: by 10.99.96.87 with SMTP id u84mr11912305pgb.407.1510664029815; Tue, 14 Nov 2017 04:53:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510664029; cv=none; d=google.com; s=arc-20160816; b=IXZyjgLS4K5JUqjrQok1DzgawxzjbQSc9xxeFqgPhbGr4vP5NqaWPYhwFzybZhyMUo m/DSnQjSSUZGXSAFhcOW9Dmcbz+Ifw+akMINM/BfW0itul8UVpS2UW0HpqodP/RCbOes sK5l17WfN5p9QcgKPUTTeUPVXopGc3CNRBTihtvpZ+OdnikHeFzGkhTuVx+XKKcV8EU8 QuRkKjDIWvDX2ORdWkw59rPotrYuI45V1Aei73IW3X2aAUbs7Xkr5YMq3n712ecBvRAi r2raQK50o4qAktYQYgeoSpTLgQFbw7uV/RjvnzzBV3vvTcW6acczOQOhwea/mCMtnAum T61Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=5kPHustJ6+Krh58rcRFEm8lPnsxm2x+2GMtDUKyqqvA=; b=Y97j/1+0YZVdykyp5DbKK1h2revIVhajRND/nVVsi89xc1mZg3H+ADq+Cf0g5536IQ wQt6xqTT1CuyDEcQBHzjQxpjnr/7qQOxVcW2HwYyHXU4NVs8Pr/TreI59feuMhKN8bvo UEArhl6U+y9RY4Nl6ljoyvCY9qpaIfJuGiP+a7sbyPXJWuvAuUMJ+TSAabcnkI7XUwbN aagv2zGCVFleoPTrgd6YltNHtYlZr9ESGLbkBwPpXn5cYURJt4c7bc/cxnXM4JGdd6PP ZZWI2Py8GKzga0MNAkKEadOmd3znHmBx+BbzWIgXrwvD92G61xw8JmNKez3qnsYR0J7A 1/kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EFygh6fX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z13si15330995pgp.767.2017.11.14.04.53.37; Tue, 14 Nov 2017 04:53:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EFygh6fX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976AbdKNMwN (ORCPT + 88 others); Tue, 14 Nov 2017 07:52:13 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:54579 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754797AbdKNMvy (ORCPT ); Tue, 14 Nov 2017 07:51:54 -0500 Received: by mail-pg0-f68.google.com with SMTP id c123so7267600pga.11; Tue, 14 Nov 2017 04:51:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=5kPHustJ6+Krh58rcRFEm8lPnsxm2x+2GMtDUKyqqvA=; b=EFygh6fXm779EzaSKwJR9FH+zcEufMVKL9NEb6WjXl4WW8I78cbzwvSLi24DBlUVqg 4wlaWmW6XwZNvNA6T+aPeUbSIuaxrayM03ngYXHT57vc3Sedz/OlGhBbyU/3+3Q8LhY9 lBkyqO9e9qNmXf9yinepvpA36Lze6Q+Z+Wri1TTrq6gyWrHsNh+MK2SJcuQb6BRqOa+u QGEO4gkIejUr3CfQW+2DfHoZ4Ni0xEAVKRQEexxAoUMTfDlufBs+B/ir7LUQ+PtkZyWo RzIvuG6LF+YaL+/29NVawP02hop4UYWTnu5QQmFny73ypqQCTc4/CrufmSqPIN/jafy+ OmaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5kPHustJ6+Krh58rcRFEm8lPnsxm2x+2GMtDUKyqqvA=; b=kKSiakHvO47leooMtA8oY9luhFzThPX40yUI9AXiurNPRVlzJgr6tEvK4/+BYG3Iop p6vKztKhBj6gndPKUIdTw21ZZUaKIw7yrMmeqEXnw62LUTh1Ee1RNyADl9Wq8bmVPwXN LZtMhb0SvsXdOvCpBBMwYAS4DRyLyHAmbya3gFczIOEGnr9k31f/pWXL0KO9cAesAfEx f9kAJ7oC+cc9g/qKCVIVkt0/w/KJrDWkAl6iU+CbTEb1BAUIpj61bF4CYJsyJ2kpFrz9 9jfE30dpsVO8nrRD3PlExnHxC45qRUJa2gBj6T0S1vJLuLxHbAjJAy16CCYTXrcrlzYX i+5g== X-Gm-Message-State: AJaThX5XICQxiRccsEjbSMSxnOQhYqaY0+LXePDAMyKkOLwV+EyR5ss8 cm3eE7LXbdad2o3cwtVnIrIuyw== X-Received: by 10.159.216.141 with SMTP id s13mr12405471plp.377.1510663913513; Tue, 14 Nov 2017 04:51:53 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id l14sm36342635pgn.35.2017.11.14.04.51.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 14 Nov 2017 04:51:52 -0800 (PST) From: Arvind Yadav To: selvin.xavier@broadcom.com, devesh.sharma@broadcom.com, somnath.kotur@broadcom.com, sriharsha.basavapatna@broadcom.com, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: [PATCH] RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call Date: Tue, 14 Nov 2017 18:20:56 +0530 Message-Id: <9fe13af401074304e355c6d1c5138b63e03b8da8.1510663723.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The bnxt_qplib_disable_nq() call is redundant as it occurs after 'goto fail' and hence it called twice. Remove it. Signed-off-by: Arvind Yadav --- drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c index e8afc47..bb7cf5e 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c @@ -409,7 +409,6 @@ int bnxt_qplib_enable_nq(struct pci_dev *pdev, struct bnxt_qplib_nq *nq, if (rc) { dev_err(&nq->pdev->dev, "Failed to request IRQ for NQ: %#x", rc); - bnxt_qplib_disable_nq(nq); goto fail; } -- 1.9.1 From 1584050965205814301@xxx Tue Nov 14 14:12:01 +0000 2017 X-GM-THRID: 1584050965205814301 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread