Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     linux-kernel@vger.kernel.org
From:   Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <20171113130708.17790-1-chris@chris-wilson.co.uk>
Cc:     intel-gfx@lists.freedesktop.org,
        "Steven Rostedt" <srostedt@redhat.com>,
        "Peter Zijlstra" <peterz@infradead.org>,
        "Ingo Molnar" <mingo@elte.hu>,
        "Tomi Sarvela" <tomi.p.sarvela@intel.com>,
        "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
        "Daniel Vetter" <daniel.vetter@ffwll.ch>
References: <20171113130708.17790-1-chris@chris-wilson.co.uk>
Message-ID: <151065893212.20436.11129102894513744987@mail.alporthouse.com>
User-Agent: alot/0.3.6
Subject: Re: [PATCH] ftrace: Allow configuring global trace buffer size (for
 dump-on-oops)
Date:   Tue, 14 Nov 2017 11:28:52 +0000
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Chris Wilson (2017-11-13 13:07:08)
> We have recently turned on ftrace-dump-on-oops for i915's CI and an
> issue we have encountered is that the trace buffer size greatly exceeds
> the pstore capabilities; we get the tail of the oops but not the
> introduction.
> 
> Currently the global buffer size is controllable on the cmdline, but at
> the request of our CI sysadmin, we would like to add a control to the
> Kconfig as well. The rationale being the cmdline carries the temporary
> hacks that we want to eradicate, and we want to track the permanent
> configuration in .config.
> 
> I have kept the Kconfig option hidden from the user as the default
> should suffice for the majority of users; reserving the configuration
> for those that eschew the cmdline option.

Odd, by removing the prompt the default value will always override the
user value in .config.

I had to restore a 
	prompt "Global ftrace buffer size" if EXPERT
to keep it configurable.
-Chris

From 1583956820697590976@xxx Mon Nov 13 13:15:38 +0000 2017
X-GM-THRID: 1583956820697590976
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread