Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ran Wang <ran.wang_1@nxp.com>
To:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Michal Hocko <mhocko@suse.com>
CC:     Michael Ellerman <mpe@ellerman.id.au>,
        Vlastimil Babka <vbabka@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        Reza Arbab <arbab@linux.vnet.ibm.com>,
        Yasuaki Ishimatsu <yasu.isimatu@gmail.com>,
        "qiuxishi@huawei.com" <qiuxishi@huawei.com>,
        Igor Mammedov <imammedo@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, Leo Li <leoyang.li@nxp.com>,
        Xiaobo Xie <xiaobo.xie@nxp.com>
Subject: RE: [PATCH 1/2] mm: drop migrate type checks from has_unmovable_pages
Thread-Topic: [PATCH 1/2] mm: drop migrate type checks from
 has_unmovable_pages
Thread-Index: AdNcTdwxuwkeiWHpRfKAuFheVJAmNgAADAHA
Date:   Mon, 13 Nov 2017 07:33:13 +0000
Message-ID: <AM3PR04MB14895AE080F9F21E98045D99F12B0@AM3PR04MB1489.eurprd04.prod.outlook.com>
References: <AM3PR04MB14892A9D6D2FBCE21B8C1F0FF12B0@AM3PR04MB1489.eurprd04.prod.outlook.com>
In-Reply-To: <AM3PR04MB14892A9D6D2FBCE21B8C1F0FF12B0@AM3PR04MB1489.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4775c4f9-6744-4638-40e2-08d52a68cc2f
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2017 07:33:13.2157
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB516
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Michal,

<snip>

> Date: Fri, 13 Oct 2017 14:00:12 +0200
>=20
> From: Michal Hocko <mhocko@suse.com>
>=20
> Michael has noticed that the memory offline tries to migrate kernel code
> pages when doing  echo 0 > /sys/devices/system/memory/memory0/online
>=20
> The current implementation will fail the operation after several failed p=
age
> migration attempts but we shouldn't even attempt to migrate that memory
> and fail right away because this memory is clearly not migrateable. This =
will
> become a real problem when we drop the retry loop counter resp. timeout.
>=20
> The real problem is in has_unmovable_pages in fact. We should fail if the=
re
> are any non migrateable pages in the area. In orther to guarantee that
> remove the migrate type checks because MIGRATE_MOVABLE is not
> guaranteed to contain only migrateable pages. It is merely a heuristic.
> Similarly MIGRATE_CMA does guarantee that the page allocator doesn't
> allocate any non-migrateable pages from the block but CMA allocations
> themselves are unlikely to migrateable. Therefore remove both checks.
>=20
> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> Tested-by: Michael Ellerman <mpe@ellerman.id.au>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
>  mm/page_alloc.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c index
> 3badcedf96a7..ad0294ab3e4f 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -7355,9 +7355,6 @@ bool has_unmovable_pages(struct zone *zone,
> struct page *page, int count,
>  	 */
>  	if (zone_idx(zone) =3D=3D ZONE_MOVABLE)
>  		return false;
> -	mt =3D get_pageblock_migratetype(page);
> -	if (mt =3D=3D MIGRATE_MOVABLE || is_migrate_cma(mt))
> -		return false;

This drop cause DWC3 USB controller fail on initialization with Layerscaper=
 processors
(such as LS1043A) as below:

[    2.701437] xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned b=
us number 1
[    2.710949] cma: cma_alloc: alloc failed, req-size: 1 pages, ret: -16
[    2.717411] xhci-hcd xhci-hcd.0.auto: can't setup: -12
[    2.727940] xhci-hcd xhci-hcd.0.auto: USB bus 1 deregistered
[    2.733607] xhci-hcd: probe of xhci-hcd.0.auto failed with error -12
[    2.739978] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller

And I notice that someone also reported to you that DWC2 got affected recen=
tly,
so do you have the solution now?

Best regards

Ran
>=20
>  	pfn =3D page_to_pfn(page);
>  	for (found =3D 0, iter =3D 0; iter < pageblock_nr_pages; iter++) {

From 1583305876165779819@xxx Mon Nov 06 08:49:09 +0000 2017
X-GM-THRID: 1583264906851375953
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread