Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Message-ID: <35b094f6-70e0-49f2-803a-3333d7ee2524@default>
Date:   Wed, 8 Nov 2017 20:54:51 -0800 (PST)
From:   Zhenzhong Duan <zhenzhong.duan@oracle.com>
To:     <mingo@kernel.org>, <tglx@linutronix.de>, <fweisbec@gmail.com>
Cc:     Srinivas REDDY Eeda <srinivas.eeda@oracle.com>,
        Joe Jin <joe.jin@oracle.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] tick/broadcast: Remove redundant code in
 tick_check_new_device()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

There is no way a timer used as broadcast clockevent device is also used as
percpu tick clockevent device currently.

It's better to put related code in tick_install_broadcast_device(), but I feel
it's harmless to give it back to the clockevents layer. Pls correct me if I'm
wrong.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
 kernel/time/tick-common.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
index 49edc1c..9bcc866 100644
--- a/kernel/time/tick-common.c
+++ b/kernel/time/tick-common.c
@@ -320,13 +320,8 @@ void tick_check_new_device(struct clock_event_device *newdev)
 
 	/*
 	 * Replace the eventually existing device by the new
-	 * device. If the current device is the broadcast device, do
-	 * not give it back to the clockevents layer !
+	 * device.
 	 */
-	if (tick_is_broadcast_device(curdev)) {
-		clockevents_shutdown(curdev);
-		curdev = NULL;
-	}
 	clockevents_exchange_device(curdev, newdev);
 	tick_setup_device(td, newdev, cpu, cpumask_of(cpu));
 	if (newdev->features & CLOCK_EVT_FEAT_ONESHOT)
-- 
1.7.3

From 1584141518678217454@xxx Wed Nov 15 14:11:19 +0000 2017
X-GM-THRID: 1582696365421728331
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread