Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CAKwiHFjKRioprSKnje1OJe_7u8mfWtjucLop7BZRE3sw4a83ZA@mail.gmail.com>
References: <20171114065731.3602-1-rakib.mullick@gmail.com> <CAKwiHFjKRioprSKnje1OJe_7u8mfWtjucLop7BZRE3sw4a83ZA@mail.gmail.com>
From:   Rakib Mullick <rakib.mullick@gmail.com>
Date:   Tue, 14 Nov 2017 14:59:06 +0600
Message-ID: <CADZ9YHhx0CFJe_SjymuJ+UL4V4zoKgQsYtiFNZxu-SSkvviLmw@mail.gmail.com>
Subject: Re: [PATCH] lib: Avoid redundant sizeof checking in __bitmap_weight() calculation.
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <mawilcox@microsoft.com>,
        Yury Norov <ynorov@caviumnetworks.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Nov 14, 2017 at 1:23 PM, Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
>
> hint: sizeof() very rarely evaluates to zero... So this is the same as
> "is32 = 1". So the patch as-is is broken (and may explain the 1-byte
> delta in vmlinux). But even if this condition is fixed, the patch
> doesn't change anything, since the sizeof() evaluation is done at
> compile-time, regardless of whether it happens inside the inlined
> hweight_long or outside. So it is certainly not worth it to duplicate
> the loop.
>
Right, no need to duplicate the loop. Checking the objdump output, it
didn't changed anything at all. Fixed condition nullifies the vmlinux
size advantage also. Drop it.

Thanks,
Rakib.

From 1584028936696999357@xxx Tue Nov 14 08:21:53 +0000 2017
X-GM-THRID: 1584025450919787077
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread