Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Benson Leung <bleung@chromium.org>
To:     broonie@kernel.org, linux-kernel@vger.kernel.org
Cc:     harshapriya.n@intel.com, naveen.m@intel.com,
        srinivas.kandagatla@linaro.org, cychiang@chromium.org,
        dgreid@chromium.org, anatol.pomozov@gmail.com, bleung@chromium.org,
        bleung@google.com
Subject: [PATCH 4/5] ASoC: rk3399_gru_sound: Map BTN_0 to KEY_PLAYPAUSE
Date:   Wed, 22 Nov 2017 12:56:42 -0800
Message-Id: <20171122205643.99783-5-bleung@chromium.org>
In-Reply-To: <20171122205643.99783-1-bleung@chromium.org>
References: <20171122205643.99783-1-bleung@chromium.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

The Android 3.5mm Headset jack specification mentions that BTN_0 should
be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE,
which has much broader userspace support.

For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle
play/pause of videos and audio, but does not handle KEY_MEDIA.

Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the
new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
https://source.android.com/devices/accessories/headset/usb-headset-spec

Signed-off-by: Benson Leung <bleung@chromium.org>
---
 sound/soc/rockchip/rk3399_gru_sound.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c
index d64fbbd50544..fa6cd1de828b 100644
--- a/sound/soc/rockchip/rk3399_gru_sound.c
+++ b/sound/soc/rockchip/rk3399_gru_sound.c
@@ -206,7 +206,8 @@ static int rockchip_sound_da7219_init(struct snd_soc_pcm_runtime *rtd)
 		return ret;
 	}
 
-	snd_jack_set_key(rockchip_sound_jack.jack, SND_JACK_BTN_0, KEY_MEDIA);
+	snd_jack_set_key(
+		rockchip_sound_jack.jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
 	snd_jack_set_key(
 		rockchip_sound_jack.jack, SND_JACK_BTN_1, KEY_VOLUMEUP);
 	snd_jack_set_key(
-- 
2.15.0.448.gf294e3d99a-goog


From 1583962742326582360@xxx Mon Nov 13 14:49:45 +0000 2017
X-GM-THRID: 1583962742326582360
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread