Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Dexuan Cui <decui@microsoft.com>
To:     "'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>,
        "Stephen Hemminger" <sthemmin@microsoft.com>,
        KY Srinivasan <kys@microsoft.com>,
        "'driverdev-devel@linuxdriverproject.org'" 
        <driverdev-devel@linuxdriverproject.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] vmbus: unregister device_obj->channels_kset
Thread-Topic: [PATCH] vmbus: unregister device_obj->channels_kset
Thread-Index: AdNcIakcW/ybML40TrKxCZmYBFSIBw==
Date:   Mon, 13 Nov 2017 01:53:33 +0000
Message-ID: <KL1P15301MB00068073D28F50BA10503F2BBF2B0@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=decui@microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-11-12T17:53:30.4034037-08:00;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic;
 Sensitivity=General
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=decui@microsoft.com; 
x-originating-ip: [73.225.236.69]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;KL1P15301MB0007;6:2FH2lxLHoUEjxH/dqvKYHxujvlkI1z/hP7t6og/okrzy2sJnFJkduSpXTX/lchYrj8+C6alS9APQHDdey2VylO5WZOQCXROVfhNEzGRdCSrSkn14cQsVONpn5EvSOzR2MQ08fMqE9Fg1pBx0ppyLtkNj9Z/gZzJr815i+UMYY6gIEdmtu3C+95iDz9coENz+7lPpTULSPQyjxDxo+3mxQhVXpM1u8LQ3yMocEH7/JFUuhslpoJ5WyJ/Cp0uB54dbuxKjmXFehN/cQQuoe+UyGzhJgaucst/KDkpIicvRcD2ngmDwftC0LRIzjkfd7uSgTQtlIowGRTmgM8ig858ksT9obVbCpu/lx/JxvYyvldQ=;5:PELE02wStNbteJECDddKAmiY2nvw26ToPA4qOwJZuB7c05BQXnfykRoni+Wnn2hR8RSO9DdMgTwexdn+iLM3JB1Wb1HZBvxQ7fSFJX9e0F4OtfhCXDc/vejf7IDwOYxPG/ToR8oqQYumO4qsjgTrbVWyObdpaugNe6xWDkwqPEs=;24:PAVP3s1OwkkgRVDxws2mccMgyvZlKeBu42gMF94mKK6F6vLpL3RNQH8XwdK4cCKkyuvE/Y8QIPHxXICDWhiclCIHLYqxf6Zz9bWJ2x0lUH8=;7:qZt+p/hvNobzM7I1nFcby2lQCpnS3w208mzh8g+tzgK6tC8IrUXTchOnaKRGCjIRsbIg9dm4poL5Nr3AM8t5MF74PmpK+08v2zqtVD2xozWpl3H9ndCepcEsBJX7YT/t15SwJ/c1qPmcP8Vdt1DtOJks98N2svYYlgyIDUJWBgzt5gNqVwGgH8GpmMshkIC2gE1SraEpgggNlOYJYCp7RKJB4EfajNezvZKxwZSNI40FzQt38wxr9jQByE7hFpEW
x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR;
x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(346002)(376002)(47760400005)(189002)(199003)(110136005)(189998001)(97736004)(105586002)(106356001)(53936002)(7736002)(66066001)(54356999)(8990500004)(50986999)(8936002)(99286004)(9686003)(6436002)(55016002)(77096006)(74316002)(6506006)(14454004)(33656002)(2421001)(81166006)(81156014)(8676002)(7696004)(10290500003)(10090500001)(478600001)(2900100001)(5660300001)(4326008)(101416001)(2906002)(3846002)(102836003)(6116002)(305945005)(22452003)(25786009)(86362001)(68736007)(86612001)(3280700002)(3660700001)(1511001)(316002)(2561002)(491001);DIR:OUT;SFP:1102;SCL:1;SRVR:KL1P15301MB0007;H:KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en;
x-ms-office365-filtering-correlation-id: 0749f230-01ee-4e91-c33c-08d52a395902
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);SRVR:KL1P15301MB0007;
x-ms-traffictypediagnostic: KL1P15301MB0007:
x-microsoft-antispam-prvs: <KL1P15301MB00079FE4CFE44C20EB19CA35BF2B0@KL1P15301MB0007.APCP153.PROD.OUTLOOK.COM>
x-exchange-antispam-report-test: UriScan:(89211679590171);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(3231022)(6055026)(61426038)(61427038)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:KL1P15301MB0007;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:KL1P15301MB0007;
x-forefront-prvs: 0490BBA1F0
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0749f230-01ee-4e91-c33c-08d52a395902
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2017 01:53:33.2336
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1P15301MB0007
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info")

Without the patch, a device can't be thoroughly destroyed, because
vmbus_device_register() -> kset_create_and_add() still holds a reference
to the hv_device's device.kobj.

Signed-off-by: Dexuan Cui <decui@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
---

The patch is based on char-misc.git's char-misc-next branch.

 drivers/hv/vmbus_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 6a86746..4f3faf5 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1378,6 +1378,8 @@ void vmbus_device_unregister(struct hv_device *device=
_obj)
 	pr_debug("child device %s unregistered\n",
 		dev_name(&device_obj->device));
=20
+	kset_unregister(device_obj->channels_kset);
+
 	/*
 	 * Kick off the process of unregistering the device.
 	 * This will call vmbus_remove() and eventually vmbus_device_release()
--=20
2.7.4


From 1584232886430719602@xxx Thu Nov 16 14:23:34 +0000 2017
X-GM-THRID: 1584232886430719602
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread