Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 13 Nov 2017 14:02:27 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Egil Hjelmeland <privat@egil-hjelmeland.no>
Cc:     vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: dsa: lan9303: Clear offload_fwd_mark
 for IGMP
Message-ID: <20171113130227.GC22473@lunn.ch>
References: <20171110115435.4261-1-privat@egil-hjelmeland.no>
 <20171110115435.4261-3-privat@egil-hjelmeland.no>
 <2e0d170e-08f6-4009-e422-6faea463a0c2@egil-hjelmeland.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2e0d170e-08f6-4009-e422-6faea463a0c2@egil-hjelmeland.no>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> RTFM, my bad. The lan9303 has both STP and IGMP bits in the receive tag. It
> is as simple as:
> 
> u16 lan9303_tag1 = ntohs(lan9303_tag[1]);
> skb->offload_fwd_mark = !(lan9303_tag1 & 0x18);

Hi Egil

That is much nicer. But please add a couple of #defines for the 0x18
bits.

	Andrew

From 1583956334517218411@xxx Mon Nov 13 13:07:54 +0000 2017
X-GM-THRID: 1583680264397303225
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread