Received: by 10.223.164.202 with SMTP id h10csp173131wrb; Mon, 13 Nov 2017 04:44:13 -0800 (PST) X-Google-Smtp-Source: AGs4zMbnIBO4vZYnwHbBX0Qw8R0LNNOQraNw5tO/8Kdcm7iL+d2u/lrEwGvM6zxw5qrPlPQS6YJW X-Received: by 10.101.80.205 with SMTP id s13mr8559260pgp.68.1510577053398; Mon, 13 Nov 2017 04:44:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510577053; cv=none; d=google.com; s=arc-20160816; b=A26wpzD+Bvaut/VR3Zly6Ll4jEZG4ytubPpQXEMg1F1A1H6saI07+mCrkDFLUcM5Vh H2ouTZSvH+4jxrTLpmmdcDCc2C4zXv2czl3ouQCvmCR8zFbrlmSq7qdd44ZaunvF60Cv Y+K+EbDk3KMAu9wDruvJFWdJmTDRhN2G7SpU+p/eCdb0yRL6KX+Vs1ZstHf5y3BOU3qa BXNHLvB5GJQv0s9If0IAzkF9iw7kpD0nwifCNvKuCdY4IyfL0aQ3DVW8J1X/eIogpGEw GFx6Fc6c8KfI5eBkNEh1qFaZdEe4tqn+mO94iTgDXsOlKkwi5gser7WXzioT+I0cZs4q eIyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=LlmkpeJp0RV6OZzG5sX8rezMVQAWhLs3bGks4PsM8/o=; b=TcxW0azw46gJLnJl/ewTUa7B/lPecn+Vq181Cf1vOa2Cy/J99DRK1PTpvl3ukXIaI6 TznU1+Y+A9WLy/yHq84+kGJPOOYPVuAB3c9doQk0xbqvFbRUJm2unLxAdim/DjvrYndj 3Mq2gnPzIoKxDfHBzPKWT0TgkQI/D9jMwGPklapS0V+tLoxENS8ZCNp35g/I2P5HXRCT 1bqHi0CGvmutxAMujv+VqqtrULxNt74l1HIcTsjXndtbvas2brZTvNWhzC9cPKzwaB+b IrAcvHSTvTeWM1FsdtHrFaKexsn9bhNvJQgrQ6oN16BKrBJMFerfzmq100ussPeghH4R cTMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d12si11448808pgn.478.2017.11.13.04.43.59; Mon, 13 Nov 2017 04:44:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbdKMMnV (ORCPT + 95 others); Mon, 13 Nov 2017 07:43:21 -0500 Received: from mail.us.es ([193.147.175.20]:39820 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbdKMMnU (ORCPT ); Mon, 13 Nov 2017 07:43:20 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 7693A392E16 for ; Mon, 13 Nov 2017 13:43:18 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 54F85BAC4D for ; Mon, 13 Nov 2017 13:43:18 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 53460BAC4A; Mon, 13 Nov 2017 13:43:18 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, HEADER_FROM_DIFFERENT_DOMAINS,SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 8F039BAC26; Mon, 13 Nov 2017 13:43:15 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 13 Nov 2017 13:43:15 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (129.166.216.87.static.jazztel.es [87.216.166.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 3314E403DF98; Mon, 13 Nov 2017 13:43:15 +0100 (CET) Date: Mon, 13 Nov 2017 13:43:14 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Liping Zhang , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net-next] netfilter: add ifdef around ctnetlink_proto_size Message-ID: <20171113124314.GA6695@salvia> References: <20171107141214.3312784-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171107141214.3312784-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 07, 2017 at 03:11:51PM +0100, Arnd Bergmann wrote: > This function is no longer marked 'inline', so we now get a warning > when it is unused: > > net/netfilter/nf_conntrack_netlink.c:536:15: error: 'ctnetlink_proto_size' defined but not used [-Werror=unused-function] > > We could mark it inline again, mark it __maybe_unused, or add an #ifdef > around the definition. I'm picking the third approach here since that > seems to be what the rest of the file has. Applied, thanks Arnd. From 1583456763764804053@xxx Wed Nov 08 00:47:26 +0000 2017 X-GM-THRID: 1583456763764804053 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread