Received: by 10.223.164.202 with SMTP id h10csp1340278wrb; Wed, 8 Nov 2017 02:46:09 -0800 (PST) X-Google-Smtp-Source: ABhQp+QhOA4ygBi5+H5aPC6cbNoao1IfGLgqxZOulOkjCcR8cLrjkGXjDXMsq9GokB352/OCH3zU X-Received: by 10.84.195.36 with SMTP id i33mr75434pld.38.1510137969445; Wed, 08 Nov 2017 02:46:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510137969; cv=none; d=google.com; s=arc-20160816; b=tgmpJxEbg0+KS5DU27fatO+jM/1ufpGjfQl7wtpXK4cGBRRzauFw+AfNVM6qsMVYEG 4DxWb+63dmo+eomxSH0LLNxZl9kyBKuhSj4VCvDWcmQFiR1drCy+iF7voSsQ80YedPvV AFJdcD4DDx3WMFWQCZwAxLlt4Ri9M1XgZ/wiimIJAt+fjgoO6l3KkIa/iSVYq+uNR5xQ cspKEONMmt9eMJw9ZFgcw+hwh3dcawUJ+qQZOO3V5QTWm1YDr3MO+t8QpzLvvIJMp5hS nHFoW/qZzwRPwLaHLSDjeYK2J0Q7UZN3SuMegpFh1ap8PFWGJGh4odkNgSGmE/rQI4U7 DIzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=WERkCUrYdfRWx9CoqmLGe1VLbJQmUp8poL0xaH0cMIk=; b=P0Yn/aCAw38KMgxcuTGoJ3BimTKhrDI3ojKW50kLbKLMfdjZDIpiQzYUYIaV6QFLh4 RW8wNkLLMLtphbhJyYila8F2OcGxZgMs4NzYJktOCe/Uft/k+vXn78au8guf29u9vDYz UUP7+SZjBGLDZuqh0ZUdAltathGeb0xBiMzPmHya/Pt2nOnvJzk5AE9wm15tdCE7z5HS vpLqkRF6pU8sh7yc2HOWph7T1wRtFKXrGG/ma0Yoh0oszGS5YjB+W7eucL62ILoeQxAD 2vZc/TRBpuQSfhocUDZJ4xzrZ3PIeF2z0M5k43z6tHOIhkrtBtZja28NKoYBUMoFa1rJ W8lQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c9si3378775pgq.470.2017.11.08.02.45.56; Wed, 08 Nov 2017 02:46:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbdKHKpQ (ORCPT + 91 others); Wed, 8 Nov 2017 05:45:16 -0500 Received: from aibo.runbox.com ([91.220.196.211]:50168 "EHLO aibo.runbox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbdKHKpO (ORCPT ); Wed, 8 Nov 2017 05:45:14 -0500 Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1eCNr3-0000qb-Ci; Wed, 08 Nov 2017 11:45:09 +0100 Received: from 93.89.113.32.ip.vitnett.no ([93.89.113.32] helo=localhost.localdomain) by mailfront10.runbox.com with esmtpsa (uid:646232 ) (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1eCNqb-0003Mq-4M; Wed, 08 Nov 2017 11:44:41 +0100 From: Egil Hjelmeland To: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Egil Hjelmeland Subject: [PATCH net-next] net: dsa: lan9303: Fix lan9303_alr_del_port() Date: Wed, 8 Nov 2017 11:44:36 +0100 Message-Id: <20171108104436.12817-1-privat@egil-hjelmeland.no> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix embarrassing bug in lan9303_alr_del_port(): Instead of zeroing entr->mac_addr, I destroyed the next cache entry. Affected .port_fdb_del and .port_mdb_del. Fixes: 0620427ea0d6 ("net: dsa: lan9303: Add fdb/mdb manipulation") Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c index 320651a57c6f..c0910aebc037 100644 --- a/drivers/net/dsa/lan9303-core.c +++ b/drivers/net/dsa/lan9303-core.c @@ -702,7 +702,7 @@ static int lan9303_alr_del_port(struct lan9303 *chip, const u8 *mac, int port) entr->port_map &= ~BIT(port); if (entr->port_map == 0) /* zero means its free again */ - eth_zero_addr(&entr->port_map); + eth_zero_addr(entr->mac_addr); lan9303_alr_set_entry(chip, mac, entr->port_map, entr->stp_override); return 0; -- 2.11.0 From 1583967782664542656@xxx Mon Nov 13 16:09:52 +0000 2017 X-GM-THRID: 1583425199332481732 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread