Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757592AbYANWYD (ORCPT ); Mon, 14 Jan 2008 17:24:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755619AbYANWRG (ORCPT ); Mon, 14 Jan 2008 17:17:06 -0500 Received: from mx2.suse.de ([195.135.220.15]:55065 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755834AbYANWQz (ORCPT ); Mon, 14 Jan 2008 17:16:55 -0500 From: Andi Kleen References: <200801141116.534682000@suse.de> In-Reply-To: <200801141116.534682000@suse.de> To: linux-kernel@vger.kernel.org, jbeulich@novell.com, mingo@elte.hu, tglx@linutronix.de Subject: [PATCH] [21/31] CPA: Dump pagetable when inconsistency is detected Message-Id: <20080114221654.18C1814F83@wotan.suse.de> Date: Mon, 14 Jan 2008 23:16:54 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2459 Lines: 77 When c_p_a() detects a inconsistency in the kernel page tables it BUGs. When this happens dump the page table first to avoid one bug reporting round trip. Signed-off-by: Andi Kleen --- arch/x86/mm/pageattr_32.c | 11 ++++++++++- arch/x86/mm/pageattr_64.c | 11 ++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) Index: linux/arch/x86/mm/pageattr_64.c =================================================================== --- linux.orig/arch/x86/mm/pageattr_64.c +++ linux/arch/x86/mm/pageattr_64.c @@ -12,6 +12,7 @@ #include #include #include +#include enum flush_mode { FLUSH_NONE, FLUSH_CACHE, FLUSH_TLB }; @@ -231,8 +232,16 @@ __change_page_attr(unsigned long address set_pte(kpte, pfn_pte(pfn, ref_prot)); BUG_ON(page_private(kpte_page) == 0); page_private(kpte_page)--; - } else + } else { + /* + * When you're here you either set the same page to PAGE_KERNEL + * two times in a row or the page table reference counting is + * broken again. To catch the later bug for now (sorry) + */ + printk(KERN_ERR "address %lx\n", address); + dump_pagetable(address); BUG(); + } /* on x86-64 the direct mapping set at boot is not using 4k pages */ BUG_ON(PageReserved(kpte_page)); Index: linux/arch/x86/mm/pageattr_32.c =================================================================== --- linux.orig/arch/x86/mm/pageattr_32.c +++ linux/arch/x86/mm/pageattr_32.c @@ -13,6 +13,7 @@ #include #include #include +#include #define PG_deferred PG_arch_1 @@ -252,8 +253,16 @@ __change_page_attr(struct page *page, pg set_pte_atomic(kpte, mk_pte(page, PAGE_KERNEL)); BUG_ON(page_private(kpte_page) == 0); page_private(kpte_page)--; - } else + } else { + /* + * When you're here you either set the same page to PAGE_KERNEL + * two times in a row or the page table reference counting is + * broken again. To catch the later bug for now (sorry) + */ + printk(KERN_ERR "address %lx\n", address); + dump_pagetable(address); BUG(); + } /* * If the pte was reserved, it means it was created at boot -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/