Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: staging: pi433: Possible bug in rf69.c
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
References: <709d3e3f-be3b-aa98-1cf6-6a048ef14d7b@smarthome-wolf.de>
 <20171110193258.qv6dbokqpjrrq3yb@mwanda>
 <a8d75f3c-b7b1-19eb-4ecb-54b9a003d34c@smarthome-wolf.de>
 <20171111084501.chwx5ku2senlgdza@mwanda>
From:   Marcus Wolf <marcus.wolf@smarthome-wolf.de>
Message-ID: <2e82e800-618a-b332-41c8-ee8aa97da88b@smarthome-wolf.de>
Date:   Sat, 11 Nov 2017 11:42:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171111084501.chwx5ku2senlgdza@mwanda>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Dan,

thanks fot the link. I can't remeber, why and what I wanted to redo. 
Maybe there was a complaint about the format of the patch...

In that patch, we also have the topic with the '>> 3', we were 
discussing a few days ago!

I'd suggest, not to invest the history any more. I'm ok with preparing a 
new patch/new patches, so we can import the fixes.

I also have several improvements for the rf69.c, I'd like to offer.

But I still need to know when to use staging and when to use linux-next.
I don't want to prepare patches for the wrong tree.

Cheers,

Marcus


Am 11.11.2017 um 10:45 schrieb Dan Carpenter:
> On Sat, Nov 11, 2017 at 08:55:30AM +0100, Marcus Wolf wrote:
>> Hi Dan,
>>
>> I checked it on my local SVN. You are right. I submitted the code with '&'.
>> Accodring to a check-in message on my SVN, there was a bugreport end of
>> July and most probably a patch - either from me, you, Joseph Wright,
>> Colin King or Julia Lawall, changing '&' to '|'. I guess the patch for
>> some reason wasn't accepted, but fortunatley I introduced the change to
>> my SVN.
> 
> You sent the patch, but then talked about sending a new version so
> that's why it wasn't merged.  Greg probably would have merged it as-is
> if it hadn't sounded like you were going to redo it.
> 
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2017-July/108821.html
> 
> regards,
> dan carpenter
> 

From 1583758671800643897@xxx Sat Nov 11 08:46:08 +0000 2017
X-GM-THRID: 1583700679179870250
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread