Received: by 10.223.164.202 with SMTP id h10csp107854wrb; Mon, 13 Nov 2017 03:34:19 -0800 (PST) X-Google-Smtp-Source: AGs4zMYT8YWynacV4wRTc4/5yyciv3sJOaIN4Kjz6L4tX/2Ao/JaTWQEUJgqaYZaXJSSOcfBFvHn X-Received: by 10.101.100.77 with SMTP id s13mr8354068pgv.15.1510572859045; Mon, 13 Nov 2017 03:34:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510572859; cv=none; d=google.com; s=arc-20160816; b=hkZJ2lnicu88cm+HySgGQh5CS8u6F3GL5MDbFnxYfuHaLM603MVOk7p2JiEfc5nBvs R8ST3YQeBuRDhBG1uGuzk0mm7qvae1/OZuHlHxV3HhpwFwDjD9meUCqkYb3OAsko6UMa o3M8IpxIwC6LEd0xSahRDeTMrL6txT8CMNx7V5vioyYUsrAZWUTome1ndvGyw1ghXwko 6wbdSYkebuVnqsM90susjfxtvvId5kkKGEG71L3GDOQOnBiR085+Ok1RC30zY9XUqXoE XFEQiNILMrydfdTAKp3fHx92RHy7pfONhniUzxqLIWQRc8appvgaWyZuanE0uceHQve4 m0bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:arc-authentication-results; bh=cFGFmzf+gruDKS9OEl0FAbjwN2xQ7gIzNC/5DolRKY0=; b=eBfw4KgTUft/YedhYe0NCfkTQ/c3kxlk9uZFANO4VZPaMIvedtGwrLaa0pwVse/CQM SZXB9I+p1JrgPoyt/CV1OHB/1q/0XWIuX/oJ0p2I26DCPod13+2DC6t36xcgiMisRBzE nFb3a+8wg9eP17F49IQ7KwseP3MC0MKH2oHJKMV8/+2zPyoXNVseNiNAf9O7UpE6Wet0 RsN3YJkf8q/m068a7O/YCB+GnBPcUCI42bobXid6qO5/RTBPuWRaUXZ9LJX/pLOTATg7 IE1xVrnWmrHmYXHK9X4deiXRSmN64Grc8mtNhCWi+cpxCwb76h2OgG+13We02M0d7gLm Mg4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l3si15159240pff.82.2017.11.13.03.34.06; Mon, 13 Nov 2017 03:34:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752666AbdKMLdO (ORCPT + 95 others); Mon, 13 Nov 2017 06:33:14 -0500 Received: from aibo.runbox.com ([91.220.196.211]:52560 "EHLO aibo.runbox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752163AbdKMLdM (ORCPT ); Mon, 13 Nov 2017 06:33:12 -0500 Received: from [10.9.9.212] (helo=mailfront12.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1eECz9-0002oo-OE; Mon, 13 Nov 2017 12:33:03 +0100 Received: from 93.89.113.32.ip.vitnett.no ([93.89.113.32] helo=[10.5.202.90]) by mailfront12.runbox.com with esmtpsa (uid:646232 ) (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) id 1eECyi-0005Xe-04; Mon, 13 Nov 2017 12:32:36 +0100 Subject: Re: [PATCH 0/2] net: dsa: lan9303: check error value from devm_gpiod_get_optional() To: Phil Reid , andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bianpan2016@163.com, stable@vger.kernel.org References: <1510560473-26727-1-git-send-email-preid@electromag.com.au> From: Egil Hjelmeland Message-ID: <6f13774a-4644-5721-61b0-f41e05021208@egil-hjelmeland.no> Date: Mon, 13 Nov 2017 12:32:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1510560473-26727-1-git-send-email-preid@electromag.com.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13. nov. 2017 09:07, Phil Reid wrote: > Replaces Pan Bian patch > "net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional" > > Errors need to be prograted back from probe. > > Note: I have only compile tested the code as I don't have the hardware. > > Phil Reid (2): > net: dsa: lan9303: make lan9303_handle_reset() a void function > net: dsa: lan9303: check error value from devm_gpiod_get_optional() > > drivers/net/dsa/lan9303-core.c | 21 ++++++++++++--------- > 1 file changed, 12 insertions(+), 9 deletions(-) > I tried this on our HW lan9303, it did not break anything. Egil From 1583937601456856800@xxx Mon Nov 13 08:10:09 +0000 2017 X-GM-THRID: 1583937553417041728 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread