Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] net: sfc: remove redundant variable start
To:     Colin King <colin.king@canonical.com>,
        Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
        Edward Cree <ecree@solarflare.com>, <netdev@vger.kernel.org>
CC:     <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20171109080122.3254-1-colin.king@canonical.com>
From:   Bert Kenward <bkenward@solarflare.com>
Message-ID: <7992c6f6-f847-95b5-b16f-cbecdb05d439@solarflare.com>
Date:   Thu, 9 Nov 2017 08:39:36 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171109080122.3254-1-colin.king@canonical.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09/11/17 08:01, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable start is assigned but never read hence it is redundant
> and can be removed. Cleans up clang warning:
> 
> drivers/net/ethernet/sfc/ptp.c:655:2: warning: Value stored to 'start'
> is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Bert Kenward <bkenward@solarflare.com>

Thanks Colin.

> ---
>  drivers/net/ethernet/sfc/ptp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
> index 56c2db398def..caa89bf7603e 100644
> --- a/drivers/net/ethernet/sfc/ptp.c
> +++ b/drivers/net/ethernet/sfc/ptp.c
> @@ -648,11 +648,9 @@ static void efx_ptp_send_times(struct efx_nic *efx,
>  	struct pps_event_time now;
>  	struct timespec64 limit;
>  	struct efx_ptp_data *ptp = efx->ptp_data;
> -	struct timespec64 start;
>  	int *mc_running = ptp->start.addr;
>  
>  	pps_get_ts(&now);
> -	start = now.ts_real;
>  	limit = now.ts_real;
>  	timespec64_add_ns(&limit, SYNCHRONISE_PERIOD_NS);
>  
> 

From 1583574741369515099@xxx Thu Nov 09 08:02:38 +0000 2017
X-GM-THRID: 1583574741369515099
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread