Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20171110115435.4261-1-privat@egil-hjelmeland.no>
 <20171110140719.GC11872@lunn.ch>
From:   Egil Hjelmeland <privat@egil-hjelmeland.no>
Message-ID: <49a8be62-683e-aac6-b3f3-eef7295a49ca@egil-hjelmeland.no>
Date:   Fri, 10 Nov 2017 19:22:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171110140719.GC11872@lunn.ch>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Den 10. nov. 2017 15:07, skrev Andrew Lunn:
>> skb->offload_fwd_mark calculation is a candidate for consolidation into the
>> DSA core. The calculation can probably be more polished when done at a point
>> where DSA has updated skb.
> 
> Hi Egil
> 
> Yes, at some point we should do this. But at the moment it is too
> early. We don't have enough experience with what the different
> switches need. I would like to see 4 or more devices doing it before
> we consolidate the code into the core.
> 

Absolutely. My point was rather I prefer not spend time polishing this 
snippet right now, because it will probably be refactored later anyway.

One steppingstone could be to make reusable helper-functions in 
net/dsa/dsa_priv.h. But I leave that to device #2 that implement this ;-)

> 	    Andrew
> 

Egil

From 1583688338820068389@xxx Fri Nov 10 14:08:13 +0000 2017
X-GM-THRID: 1583680202120308127
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread