Received: by 10.223.164.202 with SMTP id h10csp412613wrb; Wed, 8 Nov 2017 19:29:16 -0800 (PST) X-Google-Smtp-Source: ABhQp+SdZVvWHtdw12J0eK19ijeH9JLhpwbsykpu6H/buAmMdPgesnjLhavURldX3mbaLd5Y00wX X-Received: by 10.84.212.136 with SMTP id e8mr2398880pli.205.1510198156305; Wed, 08 Nov 2017 19:29:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510198156; cv=none; d=google.com; s=arc-20160816; b=kq1oItieVoBMTRpNMmNSng/4Lr66EYKvK6Y4h8MbiXzgtGafuiWIf2Ty2TIxL4zF7v d/2hMg1BiuhkoGLVpSeROKon7sFqW+6MEs9j3g6PyFc8M9+PiLUp/XVc0zvWv3YrB4AE B9fO/x8N2dTTJ99eAXgX2WAev+AZkUTQOV7tbiXSFJpaIhvLkP12oRR2CVmcgNeuAd3Y IMIXOMQH3hp8EdHtNny3425ooes20dNlZOUuWBYX2DghfoDvJl6YTlBzE6iHjG62xqLf fNeBdKHViL5BmWWfRwjpTuspgfKKa2+kYGI4W8e2uFAyD07a8I/HqziytWYXRtiImsIM 2J+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=7rvGM7UnDNP4uCPQbnZtNE+k19JWce5zBEuGkVdJOzU=; b=YDj/DzpRj5pM/JZvQ9oXwrOI5esYZbuwLDvwhFlg+L+g4lO3dpi+w+dCVgIxIK40WG IbzjRZ5w62ux9LSPPhY+0IUZBK0k0Av2vsDWjBucL8NC8Q7Mei9OOe6hWIQuDyYvJ/1w OxwXraPDKAf1e3/XUg6BZnLmjOCOe0HkXui6TVwkh1V6yvxS3AXFBw+Q5/Lgmz55x+bN 6YGaxElroHAJWkAbb7o7vEBOehD+p/eaiWW9GDP0oXwEc6e6Tliqlu0i/trZFzW/jPiu Hc0qz1K127OWHLHh3FnuIofk4c1vr0rT+9TQxuyg8nym8KTDHSXxhElRdyzmzkF48nc+ BziQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si5133307pgq.711.2017.11.08.19.29.04; Wed, 08 Nov 2017 19:29:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752143AbdKID10 (ORCPT + 82 others); Wed, 8 Nov 2017 22:27:26 -0500 Received: from gateway20.websitewelcome.com ([192.185.60.19]:34073 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbdKID1Z (ORCPT ); Wed, 8 Nov 2017 22:27:25 -0500 X-Greylist: delayed 1212 seconds by postgrey-1.27 at vger.kernel.org; Wed, 08 Nov 2017 22:27:25 EST Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 4A0D3400D2601 for ; Wed, 8 Nov 2017 21:07:13 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id CdBRehM6j5b6TCdBRev7z2; Wed, 08 Nov 2017 21:07:13 -0600 Received: from [189.175.248.21] (port=34380 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1eCdBQ-001Qcy-V7; Wed, 08 Nov 2017 21:07:13 -0600 Date: Wed, 8 Nov 2017 21:07:12 -0600 From: "Gustavo A. R. Silva" To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] Input: gamecon - mark expected switch fall-throughs Message-ID: <20171109030712.GA14989@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.248.21 X-Source-L: No X-Exim-ID: 1eCdBQ-001Qcy-V7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.175.248.21]:34380 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114761 Addresses-Coverity-ID: 114762 Signed-off-by: Gustavo A. R. Silva --- drivers/input/joystick/gamecon.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/input/joystick/gamecon.c b/drivers/input/joystick/gamecon.c index c43f087..ca734ea 100644 --- a/drivers/input/joystick/gamecon.c +++ b/drivers/input/joystick/gamecon.c @@ -654,6 +654,7 @@ static void gc_psx_report_one(struct gc_pad *pad, unsigned char psx_type, input_report_key(dev, BTN_THUMBL, ~data[0] & 0x04); input_report_key(dev, BTN_THUMBR, ~data[0] & 0x02); + /* fall through */ case GC_PSX_NEGCON: case GC_PSX_ANALOG: @@ -887,6 +888,7 @@ static int gc_setup_pad(struct gc *gc, int idx, int pad_type) case GC_SNES: for (i = 4; i < 8; i++) __set_bit(gc_snes_btn[i], input_dev->keybit); + /* fall through */ case GC_NES: for (i = 0; i < 4; i++) __set_bit(gc_snes_btn[i], input_dev->keybit); @@ -894,6 +896,7 @@ static int gc_setup_pad(struct gc *gc, int idx, int pad_type) case GC_MULTI2: __set_bit(BTN_THUMB, input_dev->keybit); + /* fall through */ case GC_MULTI: __set_bit(BTN_TRIGGER, input_dev->keybit); break; -- 2.7.4 From 1583728959626097911@xxx Sat Nov 11 00:53:52 +0000 2017 X-GM-THRID: 1583728959626097911 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread