Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 3/4] kernelshark: Adding gui_event_handlers for View
 and Graph
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     jan.kiszka@siemens.com, linux-kernel@vger.kernel.org
References: <20171110122915.24929-1-y.karadz@gmail.com>
 <20171110122915.24929-3-y.karadz@gmail.com>
 <20171110102856.5f77ef26@gandalf.local.home>
From:   Yordan Karadzhov <y.karadz@gmail.com>
Message-ID: <13e803a4-a018-2f4d-830d-5dfa2058d709@gmail.com>
Date:   Fri, 10 Nov 2017 19:58:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171110102856.5f77ef26@gandalf.local.home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10.11.2017 17:28, Steven Rostedt wrote:
> On Fri, 10 Nov 2017 14:29:14 +0200
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
>
>
>> +void trace_graph_register_gui_handler(struct graph_info *info,
>> +				      struct gui_event_handler *handler) {
>> +	handler->next = info->event_handlers;
>> +	info->event_handlers = handler;
>> +}
>> +
>
>>   
>> +void trace_view_store_register_gui_handler(TraceViewStore *store, struct gui_event_handler *handler)
>> +{
>> +	handler->next = store->event_handlers;
>> +	store->event_handlers = handler;
>> +}
>> +
>
> Hmm, and in the last patch we have:
>
> +		trace_view_store_register_gui_handler(ks_store, switch_handler);
> +		trace_view_store_register_gui_handler(ks_store, wakeup_handler);
> +
> +		trace_graph_register_gui_handler(ks_info->ginfo, switch_handler);
> +		trace_graph_register_gui_handler(ks_info->ginfo, wakeup_handler);
>
> I think I see an issue here. ;-)
>
> (Hint, what's the state of switch_handler->next and
>   wakeup_handler->next, when this is done?)
I see the issue now.
Thank you very much!
Yordan

> -- Steve


From 1583693544323161719@xxx Fri Nov 10 15:30:58 +0000 2017
X-GM-THRID: 1583682358674608028
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread