Received: by 10.223.164.221 with SMTP id h29csp1125396wrb; Wed, 1 Nov 2017 10:51:18 -0700 (PDT) X-Google-Smtp-Source: ABhQp+RcX3pcgNDTSEuBwGVhHXYPUEes1lMhBH/MPXdivO5iF9m8xD9NEleBAydfSHoMYyJ/9K0l X-Received: by 10.159.234.10 with SMTP id be10mr381521plb.386.1509558678700; Wed, 01 Nov 2017 10:51:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509558678; cv=none; d=google.com; s=arc-20160816; b=IANscg9aw6/79922wxfiDPJB6/bMyHZHki70BI4OAUQxO2pHd+74CCMLPHVYENMJ/o gLwJUyd2YETk0CA9g0soeyjVwb8q6sWqRtz59IDRvrrfp+TloQQUnI2fc+OOt8zTeooB KzFsI/hER9JFl7oabpJzEHiVUf9rZdPWMrkCk6xjK5GSEFFTVL5VvJxYHVYY7Qv0GULM Mcv1heC2Qxe9DmxbyhHidOC1X2wiFqjQ6cU8H3mf1V0EkerYPuNIKY211L4PG2Rl8Y8o igAWaX7mWCLUkdwe6HmgsKmrHc7IxxZwG8Y667YvgTjpVy+ttrfNEsZL/RvQwzXXYiSJ ycew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=C34r/zvuIgjOed08GmdrB9VtThbmbKF3/T6awvO06ok=; b=rFyITCE2DWcrtPtGK9WknLg7XS2vkusIWrORyrlUltyYkpL0tc/GtnQ1gDDPRfsxBI N79p5Lt+wK+rWNupnqGCuOn/9VQ0ntykk5v0lLKhsnlJVM8xhgLstOzlrQwy4oWrw8W3 9xHyYjVV2x73nVVY2BQ55+uXlZ06xhskHHObhBHVB4ddRup5pmVzUtteLd9qfbSU39eP yjP5rnslowPqYTmPd2MFjr4Du+7n4wQH9Bj+g3VCV5oTXp13fUK8drdjAFlTxlgsFO9R owUd4zYz6d8u19vZRk1NDHr5o9RZooyYuLONxLXKdib3jZ9NsAQC+gzwCULAq+3HwKYG 0qpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 66si1529711pgf.326.2017.11.01.10.51.05; Wed, 01 Nov 2017 10:51:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754519AbdKARts (ORCPT + 99 others); Wed, 1 Nov 2017 13:49:48 -0400 Received: from legacy.ddn.com ([64.47.133.206]:32433 "EHLO legacy.ddn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324AbdKARtq (ORCPT ); Wed, 1 Nov 2017 13:49:46 -0400 Received: from LAX-EX-CAHT1.datadirect.datadirectnet.com (10.8.103.81) by LAX-EX-CAHT2.datadirect.datadirectnet.com (10.8.103.82) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Nov 2017 10:49:45 -0700 Received: from psuche (10.8.30.131) by LAX-EX-CAHT1.datadirect.datadirectnet.com (10.8.103.81) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Nov 2017 10:49:45 -0700 Date: Wed, 1 Nov 2017 11:49:42 -0600 From: Greg Edwards To: CC: Christoph Hellwig , Al Viro , "Jens Axboe" , Subject: Re: [PATCH v2] fs: guard_bio_eod() needs to consider partitions Message-ID: <20171101174942.GJ21917@psuche> References: <20171024011007.24855-1-gedwards@ddn.com> <20171024172148.12397-1-gedwards@ddn.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171024172148.12397-1-gedwards@ddn.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [10.8.30.131] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 24, 2017 at 11:21:48AM -0600, Greg Edwards wrote: > guard_bio_eod() needs to look at the partition capacity, not just the > capacity of the whole device, when determining if truncation is > necessary. > > [ 60.268688] attempt to access beyond end of device > [ 60.268690] unknown-block(9,1): rw=0, want=67103509, limit=67103506 > [ 60.268693] buffer_io_error: 2 callbacks suppressed > [ 60.268696] Buffer I/O error on dev md1p7, logical block 4524305, async page read > > Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index") > Signed-off-by: Greg Edwards > --- > Changes from v1: > * use __disk_get_part instead of disk_get_part, similar to what > blk_partition_remap does Al, Christoph, Any thoughts on this version? It would be nice to get this fixed before 4.14 goes out, as this is a regression from previous releases. Greg From 1582160466198797349@xxx Tue Oct 24 17:23:21 +0000 2017 X-GM-THRID: 1582099735264682689 X-Gmail-Labels: Inbox,Category Forums