Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 24 Oct 2017 09:26:59 -0600
From:   Greg Edwards <gedwards@ddn.com>
To:     Christoph Hellwig <hch@lst.de>
CC:     Al Viro <viro@ZenIV.linux.org.uk>, <linux-fsdevel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs: guard_bio_eod() needs to consider partitions
Message-ID: <20171024152658.GA1477@psuche>
References: <20171024011007.24855-1-gedwards@ddn.com>
 <20171024021636.GZ21978@ZenIV.linux.org.uk>
 <20171024074615.GA14396@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20171024074615.GA14396@lst.de>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 24, 2017 at 09:46:15AM +0200, Christoph Hellwig wrote:
> On Tue, Oct 24, 2017 at 03:16:36AM +0100, Al Viro wrote:
>>> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index")
>>> Signed-off-by: Greg Edwards <gedwards@ddn.com>
>>
>> That smells like a nasty source of overhead, especially on SMP boxen...
>
> We could just use __disk_get_part similar to the partition remapping,
> or just pass the block_device to guard_bio_eod.

Do you have a preference?  __disk_get_part would be isolated to
guard_bio_eod.  If we pass in the block_device, it would also touch all
the mpage_bio_submit callers.

From 1582124233898372932@xxx Tue Oct 24 07:47:27 +0000 2017
X-GM-THRID: 1582099735264682689
X-Gmail-Labels: Inbox,Category Forums