Received: by 10.223.164.202 with SMTP id h10csp359541wrb; Fri, 10 Nov 2017 07:28:40 -0800 (PST) X-Google-Smtp-Source: AGs4zMbbCtrzo9fUZJdoltKy4WHrU4kvnvK9lTez0DAZCeV47Mv/OrS0CoVF2BDLDbZOMwLnbDcv X-Received: by 10.84.231.2 with SMTP id f2mr719556plk.256.1510327719986; Fri, 10 Nov 2017 07:28:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510327719; cv=none; d=google.com; s=arc-20160816; b=i4xh+SjVxCoITAT4QOgRg8Kk3y+xcKeDC6z4Ov7M2fJ4iy7Z6QJeFJDZhSxuvx0ksU vMb0UC+SVkMdpnEzEdPZnJxUg/ZCyfBTmNI6D/lYgLc4GOWvU3jN2AgjMlpaRgie6vLH Vjk3lwrzMMNFl3HzRxZED+aEQ+ZSK6ttzDOamcU0lcIMu9pXMe5A8IMV1P+eP09jwOFt N34XSm78kKcmsTYd2rX9mkKaWbClj/EDNmA5Uzto8Jz+0oLOgW9B8jAqXVNw7K450iXT O8LKVJrZ9vT5hho8x1O+pO7uSdaoit4SeamIGicxQ65Fz4QYcN6gcmCMPfINHv/qOirG PUpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=V0fNisAVlaXLz4pzal2LyHYSGzzJ4w9BWaC4oGDA/2E=; b=jrJdftXp62mG80YNTFOmg85+HL/rNrg1xH5/qfGYNdrvu36NI06rete3TEL//KgrWs r8h8to+VEqX7wRoOtkvR2tOl6AAUMReVQyxEXcV11x/hBr3Y2SjuJGtVqC1nxv9HkRs8 4Mc9G0PrGwVkGVrA4vvgCbacqEQxxdCz2/rBSA0W6LKkAoCzGobvufpJXoMkaPXiuCVI Jrnv8FTKpmHm8aALWkskhNvfypURL04WhRdcRtr9zyDFFwuJgFL0blXM0axZ+4mb2rmR fctjjuHa3p+d9s6bFEXYy9Kf89KnFVhuNWaM9JdV9jjGrqKT/WHgTTS3FaBtT2e+A+ED X81Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=VqlYt35t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l91si8954105plb.647.2017.11.10.07.28.28; Fri, 10 Nov 2017 07:28:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=VqlYt35t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753262AbdKJP0k (ORCPT + 82 others); Fri, 10 Nov 2017 10:26:40 -0500 Received: from mail-pg0-f49.google.com ([74.125.83.49]:44243 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610AbdKJP0i (ORCPT ); Fri, 10 Nov 2017 10:26:38 -0500 Received: by mail-pg0-f49.google.com with SMTP id j3so7637921pga.1 for ; Fri, 10 Nov 2017 07:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=V0fNisAVlaXLz4pzal2LyHYSGzzJ4w9BWaC4oGDA/2E=; b=VqlYt35tmZyZ0gIGDwoiYV9iNKfn329VtAdN2vfn0b8R9W5MnepmtkUe2rNbewNNba NfP7bmcn5qWSU+0y7ilvWdlGIf3MhponrUT+fmE19w+uqmSbLRV6huLQwkosdXFnG3qk gZOYo+Ope0qgWt8dGnS1jn1PoFHsS1U9GX8auTFQGrzuCoKyfSuGYipZNZDkCt9r8aTD EJk7dvZp/Iijt7C6xYXpn8b5KMQzHYhdVKi6QsNNnHW4OGONAvbJYp+m6uy9AYMzrGKJ ZR4155FlLnoiHUJxZ15Y88Zyd2QZx/q+ztNB0QwO7l/miR8LHmmNup1VX/0/F38L1QiP GlnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V0fNisAVlaXLz4pzal2LyHYSGzzJ4w9BWaC4oGDA/2E=; b=iQ6PiwVhnCJ7CizFjScMVN6sVRu1g4eMglQeF4+Kzg+LhEzovh9XI+yRSdYkxHdG07 d5wS4iTS8ljneGUBeGosDnFwTzYR5MbhFChhTLVAKtdb9XwHVIZ2UtJD5MQyNzafOd7K 22eEjNcGmKmpfiqusWcyaIawST6j2bwkvtHAI7j3KRqsVsSPjFfEZcMS9f03mBqk4kRf cS/9oDKjdrLhZFlITFRh6lBDCE0E8sEhdTB9+KAPQPGTx1lHR5geddmfwPegsteTy8o0 2jw6/nIRdeFgpGtKF32qE5/k6schNRJpfsLowiJVG4ac3lVuud4CNxTjkdX7ospNwAQZ QFBA== X-Gm-Message-State: AJaThX7HKYpOtvABmWdi3CEYOKKCWK1gZNop4sHkSri01P5Rv3I7gMmW 1HapJskGr2b78a46amEekJWCGTaK9kg= X-Received: by 10.101.69.137 with SMTP id o9mr672067pgq.127.1510327597542; Fri, 10 Nov 2017 07:26:37 -0800 (PST) Received: from [192.168.1.154] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id v9sm9255874pfg.85.2017.11.10.07.26.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Nov 2017 07:26:36 -0800 (PST) Subject: Re: [PATCH] block: avoid null pointer dereference on null disk To: Colin King , linux-block@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171106175353.20199-1-colin.king@canonical.com> From: Jens Axboe Message-ID: <47f5fa8a-136f-a7c3-d713-363983653d2d@kernel.dk> Date: Fri, 10 Nov 2017 08:26:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171106175353.20199-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/2017 10:53 AM, Colin King wrote: > From: Colin Ian King > > It is possible that the pointer disk can be null and hence > we can get a null pointer deference when accessing disk->flags. > Add a null pointer check to avoid the dereference. Applied, thanks. -- Jens Axboe From 1583666556789496473@xxx Fri Nov 10 08:22:00 +0000 2017 X-GM-THRID: 1583340205555903582 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread