Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755558AbYAOCDb (ORCPT ); Mon, 14 Jan 2008 21:03:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750991AbYAOCDY (ORCPT ); Mon, 14 Jan 2008 21:03:24 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:37936 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818AbYAOCDX (ORCPT ); Mon, 14 Jan 2008 21:03:23 -0500 Date: Tue, 15 Jan 2008 11:06:31 +0900 From: KAMEZAWA Hiroyuki To: KOSAKI Motohiro Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Marcelo Tosatti , Daniel Spang , Rik van Riel , Andrew Morton Subject: Re: [RFC][PATCH 4/5] memory_pressure_notify() caller Message-Id: <20080115110631.4cab1e65.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20080115100124.117B.KOSAKI.MOTOHIRO@jp.fujitsu.com> References: <20080115092828.116F.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080115100124.117B.KOSAKI.MOTOHIRO@jp.fujitsu.com> Organization: Fujitsu X-Mailer: Sylpheed 2.4.2 (GTK+ 2.10.11; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 711 Lines: 28 On Tue, 15 Jan 2008 10:02:30 +0900 KOSAKI Motohiro wrote: > + > + notify_threshold = (zone->pages_high + > + zone->lowmem_reserve[MAX_NR_ZONES-1]) * 2; > + Why MAX_NR_ZONES-1 ? > + if (unlikely((prev_free <= notify_threshold) && > + (zone_page_state(zone, NR_FREE_PAGES) > notify_threshold))) > + memory_pressure_notify(zone, 0); > } How about this == if (unlikely(zone->mem_notify_status && ...) Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/