Received: by 10.223.164.221 with SMTP id h29csp5316883wrb; Fri, 20 Oct 2017 10:08:51 -0700 (PDT) X-Received: by 10.101.64.133 with SMTP id t5mr4918363pgp.299.1508519331145; Fri, 20 Oct 2017 10:08:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508519331; cv=none; d=google.com; s=arc-20160816; b=V1t0jTBJS2qxORsfeEINdVLB75vio0IZJ+zRq23RAZZJnVMnS7sVIlqxC0s4zfjbF+ Sx8rGEbytNntgd4iwcKkxdDhXmb8i1BT5Rppt2hqR+xm7Quj61E8ITFgE+mNzz9lHt1m xKupSlgv5kGhNK367ICXLmTW4xZE7LWN9ONB+9GzgWD8K6p/aReEUvIZTBRAhMUR8XSD pJgl1vqz1urvFg0CXJtqYP/wwJi4I7YlD+d6R92DspcYD3KZX7/k0GHnpq1S15Xw41ro zTt4hL4URa6azf6nG63oGcH6COEb5m9YUAOypX5nFfEaS1Hf256ctjIUwjokdwoizEBe 0Dcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=bjSAwUwFC7ZrLLE/pmXMdpG0A9KUKCj+dlpyaM4RGpU=; b=ezADOXVcWuz8kIo2RGVb/+LkzwLBmT1sLPbQsEnbITwVz1E4RzrXAL5+oG2La9DuLp fOGRqgEBzvDlQ3IIh0J/4wy4xXRu7+pNlSkQxMdla4yf4YNRR4HjLiwSjxUSQnnHprxF 4DExgsgZbUH2w8PVPPA4AeGM/Lo7mZJJWOf4xtQ4xSABl3/pDpegfB5FQzk7Kt603w0Y HI3pyZgU6Ph2X/ga+He7wnq9eHtKxFdJwCVkOYXBBEJzVtdjvvfiDLCAT8lou0sZPrT2 hK2sVQExSv7Pg11jR6G18I7eT7CT0C9SI4R1lCTeGxphcYxKAW1ScDD+qto64zF7KILc HchA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G/Ow6ehX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m8si999263pfh.552.2017.10.20.10.08.36; Fri, 20 Oct 2017 10:08:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G/Ow6ehX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753491AbdJTRHk (ORCPT + 99 others); Fri, 20 Oct 2017 13:07:40 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:54194 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753057AbdJTRHh (ORCPT ); Fri, 20 Oct 2017 13:07:37 -0400 Received: by mail-io0-f176.google.com with SMTP id 189so13913613iow.10 for ; Fri, 20 Oct 2017 10:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bjSAwUwFC7ZrLLE/pmXMdpG0A9KUKCj+dlpyaM4RGpU=; b=G/Ow6ehXOlEPwXVrMnopUZmZBf1xn9o2v4SNT3nsa13D4d1IPHG/D1F9CMb1dc3OcX P8p8hRBM6ODAoDfn6MWWPT4XG8tgX90GgCksJWStseudgspo6tqVoMHdkSM49PX/EZSZ xvpQ8OmMTa2xeciZGy2Zjql64o58cnq5ykaq4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bjSAwUwFC7ZrLLE/pmXMdpG0A9KUKCj+dlpyaM4RGpU=; b=kGKFgZV3bU0BYXa6Kkf+QXfwOV3ybbw9FWn3tWrR3YiojO20HCu/BOAOP65Mfzfzab o2/2ryqtoPFLFTrAZyKVpmn3dMLrcFDQkCdwI1vEB22TAYNhQpPEktDGDJuxCORo4Apz EJrNAye5bw5+eylO4v+fz30ftLI43EbhR35SAvHaawynwhwXNmzJK2JemHn1GrJbRMrh o9mXZQK97yTgDBf9on9xqIjJvp5ri6KdK0L/54aOQKKiQOcyJrv7QogI1JgpC6S5qSbY 1urdL8G/11C4jeAPTpc5KSWHXAIGzlrXe7L1aTIdrKkiPZHbGxjM+fjfgGQzEON05e2n 4DsQ== X-Gm-Message-State: AMCzsaV+hb94ROmimctrbKpVpBY5Pk5G+gU8nGauL9YJplCoY+itQYFV bzHbIS9RYnGeowW3tGF1Kn2JcA== X-Google-Smtp-Source: ABhQp+SEaXV31sz36IeqP4wpIZZygjGeHfZ8XWgbg//M9EGpQH1aFnAp3LP8TnNkdzuhVBZg6QP1+A== X-Received: by 10.107.107.22 with SMTP id g22mr7764986ioc.77.1508519256752; Fri, 20 Oct 2017 10:07:36 -0700 (PDT) Received: from localhost ([2620:0:1013:0:f685:3152:9ba1:429a]) by smtp.gmail.com with ESMTPSA id e34sm507754ioj.83.2017.10.20.10.07.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Oct 2017 10:07:36 -0700 (PDT) Date: Fri, 20 Oct 2017 13:07:35 -0400 From: Sean Paul To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org, seanpaul@chromium.org, dianders@chromium.org, heiko@sntech.de, tfiga@chromium.org, Andrzej Hajda , Arnd Bergmann , Romain Perier , Russell King , Philipp Zabel , Jonathan Corbet , dri-devel@lists.freedesktop.org, Jingoo Han , David Airlie , Kevin Hilman , Catalin Marinas , Laurent Pinchart , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Seung-Woo Kim , Inki Dae , linux-rockchip@lists.infradead.org, Kyungmin Park , Carlo Caione , Will Deacon , linux-amlogic@lists.infradead.org, Caesar Wang , Matthias Kaehlcke , devicetree@vger.kernel.org, Kukjin Kim , Tomeu Vizoso , zain wang , Hans Verkuil , Archit Taneja , Joonyoung Shim , linux-arm-kernel@lists.infradead.org, Marek Szyprowski , Daniel Vetter , Mark Yao , linux-renesas-soc@vger.kernel.org, Neil Armstrong , Kieran Bingham , Rob Herring , Jose Abreu , Mark Rutland Subject: Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display Message-ID: <20171020170735.yahyoshwsewttjvy@art_vandelay> References: <20171019034812.13768-1-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171019034812.13768-1-jeffy.chen@rock-chips.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 19, 2017 at 11:48:02AM +0800, Jeffy Chen wrote: > > Make edp display works on chromebook kevin(at least for boot animation). > > Also solve some issues i meet during the bringup. > > Changes in v6: > Don't change order of rockchip_drm_psr_register(). > > Changes in v5: > Call the destroy hook in the error handling path like in unbind(). > Call the destroy hook in the error handling path like in unbind(). > Update cleanup order in unbind(). > Add disable to unbind(), and inline clk_prepare_enable() with bind(). > > Jeffy Chen (10): > arm64: dts: rockchip: Enable edp disaplay on kevin > drm/rockchip: analogix_dp: Remove unnecessary init code > drm/bridge: analogix: Do not use device's drvdata > drm/bridge: analogix_dp: Fix connector and encoder cleanup > drm/rockchip: analogix_dp: Add a sanity check for > rockchip_drm_psr_register() > drm/rockchip: dw-mipi-dsi: Fix error handling path > drm/rockchip: inno_hdmi: Fix error handling path > drm/bridge/synopsys: dw-hdmi: Add missing bridge detach > drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata > drm/rockchip: dw_hdmi: Fix error handling path Hi Jeffy, I've pushed 2/10. Once you fix 3/10, I can push 3-7. I'd like someone familiar with synopsys to review 8-9 before pushing those. Since 10 depends on 9, it'll be blocked on synopsys review. Sean > > arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 29 +++++++ > arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 16 ++++ > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 52 +++++------- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 53 ++++++------ > drivers/gpu/drm/exynos/exynos_dp.c | 29 ++++--- > drivers/gpu/drm/imx/dw_hdmi-imx.c | 22 +++-- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 20 +++-- > drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 14 +++- > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 95 +++++++++++----------- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 21 +++-- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 39 +++++---- > drivers/gpu/drm/rockchip/inno_hdmi.c | 22 +++-- > include/drm/bridge/analogix_dp.h | 19 +++-- > include/drm/bridge/dw_hdmi.h | 17 ++-- > 14 files changed, 265 insertions(+), 183 deletions(-) > > -- > 2.11.0 > > -- Sean Paul, Software Engineer, Google / Chromium OS From 1581656545107515246@xxx Thu Oct 19 03:53:44 +0000 2017 X-GM-THRID: 1581656545107515246 X-Gmail-Labels: Inbox,Category Forums