Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 10 Nov 2017 11:30:13 -0500 (EST)
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Abhijeet@vger.kernel.org, <Kumar@vger.kernel.org>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jaejoong Kim <climbbb.kim@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Abhijeet Kumar <abhijeet.kumar@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB :core :Prevent USB devices to autosuspend while
 setting interface
In-Reply-To: <1510329728-26491-1-git-send-email-abhijeet.kumar@intel.com>
Message-ID: <Pine.LNX.4.44L0.1711101128060.14906-100000@netrider.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 10 Nov 2017 Abhijeet@vger.kernel.org wrote:

> From: Abhijeet Kumar <abhijeet.kumar@intel.com>
> 
> Runtime resume USB device in order to ensure that PM framework knows
> that the we might be using the device in a short time and doesn't
> autosuspend the device while we update it's interface. Without this
> change, if device autosuspends and the kernel polling for block
> devices is disabled through sysfs at runtime or through bootargs, then
> storage devices might never unmount since the disconnect IRQ wont be
> kicked at all.
> 
> Signed-off-by: Abhijeet Kumar <abhijeet.kumar@intel.com>

I don't see any reason for doing this.  The places that call this 
subroutine will already have made sure that the device is active.  
There's no need for an additional runtime_get.

As for disconnect IRQs, they occur whether the device is suspended or 
not (they are generated by the host controller, not by the device).

Alan Stern


From 1583695921271455278@xxx Fri Nov 10 16:08:45 +0000 2017
X-GM-THRID: 1583683780321407589
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread