Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171105073121.GB1431@kroah.com>
References: <20171105025635.10843-1-asarai@suse.de> <20171105073121.GB1431@kroah.com>
From:   Aleksa Sarai <cyphar@cyphar.com>
Date:   Sun, 5 Nov 2017 20:11:20 +1100
Message-ID: <CAOviyagXOJE3JqYwd3hUNA+qL0cRVafDgma8FTvq9To9iBaYmQ@mail.gmail.com>
Subject: Re: [PATCH v3] scsi: require CAP_SYS_ADMIN to write to procfs interface
To:     Greg KH <greg@kroah.com>
Cc:     Aleksa Sarai <asarai@suse.de>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        containers@lists.linux-foundation.org,
        Valentin Rothberg <vrothberg@suse.com>, stable@vger.kernel.org,
        "Eric W. Biederman" <ebiederm@xmission.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

I've booted it on a few of my laptops, and nothing seemed to break. Is
there a particular test-suite you'd recommend that I run?

On Sun, Nov 5, 2017 at 6:31 PM, Greg KH <greg@kroah.com> wrote:
> On Sun, Nov 05, 2017 at 01:56:35PM +1100, Aleksa Sarai wrote:
>> Previously, the only capability effectively required to operate on the
>> /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files,
>> having an fsuid of GLOBAL_ROOT_UID was enough). This means that
>> semi-privileged processes could interfere with core components of a
>> system (such as causing a DoS by removing the underlying SCSI device of
>> the host's / mount).
>
> Given that the previous patch didn't even compile, I worry that you have
> not tested this at all to see what breaks/changes in userspace with this
> type of user-visable api change.
>
> What did you do to test this?
>
> thanks,
>
> greg k-h


-- 
Aleksa Sarai (cyphar)
www.cyphar.com

From 1583210504340739943@xxx Sun Nov 05 07:33:15 +0000 2017
X-GM-THRID: 1583193190987872787
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread