Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DA9F4600CE
Subject: Re: [PATCH V2 2/3] dmaengine: qcom_hidma: add support for the new
 revision
To:     Sinan Kaya <okaya@codeaurora.org>, dmaengine@vger.kernel.org
Cc:     linux-arm-msm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <1510158582-5343-1-git-send-email-okaya@codeaurora.org>
 <1510158582-5343-2-git-send-email-okaya@codeaurora.org>
 <e673a03d-1707-fe4a-7f5d-df1466981893@codeaurora.org>
 <c55ecc2c-332c-e9e6-c74c-3c67fd2ab89a@codeaurora.org>
From:   Timur Tabi <timur@codeaurora.org>
Message-ID: <fe23cb49-d617-fd79-8fb6-08d45fc88bce@codeaurora.org>
Date:   Wed, 8 Nov 2017 11:12:09 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <c55ecc2c-332c-e9e6-c74c-3c67fd2ab89a@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/08/2017 10:58 AM, Sinan Kaya wrote:
> Besides, C compiler also won't let me put two arrays together like this.
> 
> struct my_struct {
> 	struct some_struct array1[]
> 	struct some_struct array2[]
> }

Why not this:

const struct of_device_id hidma_msi_of_ids[] = {
	{.compatible = "qcom,hidma-1.1",},
	{.compatible = "qcom,hidma-1.2",},
	{},
},

static const struct acpi_device_id hidma_msi_acpi_ids[] = {
	{"QCOM8001", QDF2XXX_V1},
	{"QCOM8002", QDF2XXX_V2},
	{},
};

struct hidma_cap {
	const struct of_device_id *of;
	const struct acpi_device_id *acpi;
};

static struct hidma_cap hidma_msi_cap = {
	hidma_msi_of_ids,
	hidma_msi_acpi_ids
}

Keep in mind that you also need to add MODULE_DEVICE_TABLE entries, 
which you can't really do with your approach.

MODULE_DEVICE_TABLE(of, hidma_msi_of_ids);
MODULE_DEVICE_TABLE(acpi, hidma_msi_acpi_ids);

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

From 1583517972622368399@xxx Wed Nov 08 17:00:20 +0000 2017
X-GM-THRID: 1583516180493773162
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread