Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To:     netdev@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v2] Revert "net: dsa: constify cpu_dp member of dsa_port"
In-Reply-To: <20171109195609.28068-1-vivien.didelot@savoirfairelinux.com>
References: <20171109195609.28068-1-vivien.didelot@savoirfairelinux.com>
Date:   Thu, 09 Nov 2017 17:24:13 -0500
Message-ID: <87efp7nl9u.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi David,

Vivien Didelot <vivien.didelot@savoirfairelinux.com> writes:

> We may have to pass a port's dedicated CPU port to port-wide functions
> such as dsa_port_mdb_add, e.g. when offloading bridge device's MDB.
>
> The DSA port-wide functions currently take a non-const struct dsa_port *
> as first argument so we cannot make cpu_dp const yet, even though it'd
> be more correct. Revert this patch and make cpu_dp non-const again.
>
> This reverts commit 24a9332a58b7f41a0d36c35a2c6897242bffdbc0.

No need to apply this revert, Andrew made the dsa_port_mdb_* functions
take a const dsa_port in his new IGMP patchset so that we can keep the
cpu_dp const, as it should be.


Thanks,

        Vivien

From 1583619726855590614@xxx Thu Nov 09 19:57:40 +0000 2017
X-GM-THRID: 1583619726855590614
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread