Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     Frederic Weisbecker <frederic@kernel.org>,
        "Ingo Molnar" <mingo@kernel.org>
From:   Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <1509414414-14987-1-git-send-email-frederic@kernel.org>
Cc:     "LKML" <linux-kernel@vger.kernel.org>,
        "Byungchul Park" <byungchul.park@lge.com>,
        "Frederic Weisbecker" <frederic@kernel.org>,
        "Peter Zijlstra" <peterz@infradead.org>,
        Petri Latvala <petri.latvala@intel.com>
References: <1509414414-14987-1-git-send-email-frederic@kernel.org>
Message-ID: <151027307351.14762.4611888896020658384@mail.alporthouse.com>
User-Agent: alot/0.3.6
Subject: Re: [PATCH] irq_work: Don't reinvent the wheel but use existing llist API
Date:   Fri, 10 Nov 2017 00:17:53 +0000
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Frederic Weisbecker (2017-10-31 01:46:54)
> From: Byungchul Park <byungchul.park@lge.com>
> 
> Although llist provides proper APIs, they are not used. Make them used.
> 
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> ---
>  kernel/irq_work.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index bcf107c..e2ebe8c 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -138,11 +138,7 @@ static void irq_work_run_list(struct llist_head *list)
>                 return;
>  
>         llnode = llist_del_all(list);
> -       while (llnode != NULL) {
> -               work = llist_entry(llnode, struct irq_work, llnode);
> -
> -               llnode = llist_next(llnode);
> -
> +       llist_for_each_entry(work, llnode, llnode) {
>                 /*
>                  * Clear the PENDING bit, after this point the @work
>                  * can be re-used.

I haven't seen this reported yet, but this requires
llist_for_each_entry_safe() because as mentioned work can be linked into
another cpu's runlist after the PENDING bit is cleared.
-Chris

From 1582737050135896659@xxx Tue Oct 31 02:07:54 +0000 2017
X-GM-THRID: 1582737050135896659
X-Gmail-Labels: Inbox,Category Forums