From: Andi Kleen <ak@suse.de>
Organization: SUSE Linux Products GmbH, Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
To: Harvey Harrison <harvey.harrison@gmail.com>
Subject: Re: [PATCH] [7/31] Extract page table dumping code from i386 fault handler into dump_pagetable()
Date: Tue, 15 Jan 2008 11:00:35 +0100
User-Agent: KMail/1.9.6
Cc: linux-kernel@vger.kernel.org, jbeulich@novell.com, mingo@elte.hu,
       tglx@linutronix.de
References: <200801141116.534682000@suse.de> <20080114221639.31FC714F83@wotan.suse.de> <1200387377.16794.9.camel@brick>
In-Reply-To: <1200387377.16794.9.camel@brick>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200801151100.35927.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 927
Lines: 27

 
> > +void dump_pagetable(unsigned long address)
> 
> static?

This is used by other files too with future patches. Also
in general it's useful for debugging stuff - i often put calls 
to it into debugging patches.

> > +{
> > +	typeof(pte_val(__pte(0))) page;
> 
> Is there any type that could be picked that would be nicer than
> sprinkling ((__typeof__(page) *), typeof(pte_val(__pte(0))) etc
> through here, I know it's just moving the code out to another
> function, just wondering if you had any better ideas that someone
> could follow-up on.

It could be pteval_t now which Jeremy recently introduced. But for pure
code movement I don't want to do any improvements.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/