DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding;
        b=b2sfkHxKvQJQfZB2pXubSSD4nYHN3awZBo9yviL8tw0fb3ia+ZzCL/nqNkp1iVXesBvF6k0Lg/ETG7EKo6WlEYlGZCPG/PxEsZHMSGxUZKIn9a2df4rDZX5ze2DupFZX+l/uIBQop0AnyXO/qwgUrnhgZbvzlQ0ZltzfjmMDYaE=
Subject: Re: [PATCH] [7/31] Extract page table dumping code from i386 fault
	handler into dump_pagetable()
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, jbeulich@novell.com, mingo@elte.hu,
       tglx@linutronix.de
In-Reply-To: <200801151100.35927.ak@suse.de>
References: <200801141116.534682000@suse.de>
	 <20080114221639.31FC714F83@wotan.suse.de> <1200387377.16794.9.camel@brick>
	 <200801151100.35927.ak@suse.de>
Content-Type: text/plain
Date: Tue, 15 Jan 2008 02:05:18 -0800
Message-Id: <1200391518.16794.18.camel@brick>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1199
Lines: 32

On Tue, 2008-01-15 at 11:00 +0100, Andi Kleen wrote:
> > > +void dump_pagetable(unsigned long address)
> > 
> > static?
> 
> This is used by other files too with future patches. Also
> in general it's useful for debugging stuff - i often put calls 
> to it into debugging patches.
> 
> > > +{
> > > +	typeof(pte_val(__pte(0))) page;
> > 
> > Is there any type that could be picked that would be nicer than
> > sprinkling ((__typeof__(page) *), typeof(pte_val(__pte(0))) etc
> > through here, I know it's just moving the code out to another
> > function, just wondering if you had any better ideas that someone
> > could follow-up on.
> 
> It could be pteval_t now which Jeremy recently introduced. But for pure
> code movement I don't want to do any improvements.

Sure, I had a very similar patch but was looking for a better way to
address this, I'll keep an eye on this and Jeremy's patch and follow
up when his stuff has settled a bit more.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/