Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CAL_JsqLG05ha3ApwHJooqqZThH30p=Yu8GbXpg6RyC-2v+K=NA@mail.gmail.com>
References: <cover.1510118606.git.green.hu@gmail.com> <5d06ac8d2a19c78a445b958a1b0a925559bd9f9c.1510118606.git.green.hu@gmail.com>
 <CAL_JsqLG05ha3ApwHJooqqZThH30p=Yu8GbXpg6RyC-2v+K=NA@mail.gmail.com>
From:   Greentime Hu <green.hu@gmail.com>
Date:   Thu, 9 Nov 2017 17:49:24 +0800
Message-ID: <CAEbi=3c0vTDxzD8OicQrjhekKqF0+dNDG=cng0M7St62qDqPAA@mail.gmail.com>
Subject: Re: [PATCH 02/31] nds32: Kernel booting and initialization
To:     Rob Herring <robh+dt@kernel.org>
Cc:     Greentime <greentime@andestech.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>,
        netdev <netdev@vger.kernel.org>,
        Vincent Chen <vincentc@andestech.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2017-11-08 21:38 GMT+08:00 Rob Herring <robh+dt@kernel.org>:
> On Tue, Nov 7, 2017 at 11:54 PM, Greentime Hu <green.hu@gmail.com> wrote:
>> From: Greentime Hu <greentime@andestech.com>
>>
>
> Commit message needed.

Thanks.
I will add more commit messages in the next version patch.

>
>> Signed-off-by: Vincent Chen <vincentc@andestech.com>
>> Signed-off-by: Greentime Hu <greentime@andestech.com>
>> ---
>
>> +       /* it could update max_pfn */
>> +       if (max_pfn - ram_start_pfn <= MAXMEM_PFN)
>> +               max_low_pfn = max_pfn;
>> +       else {
>> +               max_low_pfn = MAXMEM_PFN + ram_start_pfn;
>> +#ifndef CONFIG_HIGHMEM
>
> Use IS_ENABLED here and other ifdef's if possible.
>

Thanks
I will try to use IS_ENABLED here in the next version patch.

>> +               max_pfn = MAXMEM_PFN + ram_start_pfn;
>> +#endif
>> +       }
>
>
>> +static int __init nds32_device_probe(void)
>> +{
>> +       return of_platform_populate(NULL, NULL, NULL, NULL);
>> +}
>> +
>> +device_initcall(nds32_device_probe);
>
> You can drop this. The core code will call of_platform_populate for you.

Thanks.
I will drop this in the next version patch.

From 1583505379406955528@xxx Wed Nov 08 13:40:10 +0000 2017
X-GM-THRID: 1583483485147725708
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread