Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62A5821939
MIME-Version: 1.0
In-Reply-To: <5d06ac8d2a19c78a445b958a1b0a925559bd9f9c.1510118606.git.green.hu@gmail.com>
References: <cover.1510118606.git.green.hu@gmail.com> <5d06ac8d2a19c78a445b958a1b0a925559bd9f9c.1510118606.git.green.hu@gmail.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Wed, 8 Nov 2017 07:38:42 -0600
Message-ID: <CAL_JsqLG05ha3ApwHJooqqZThH30p=Yu8GbXpg6RyC-2v+K=NA@mail.gmail.com>
Subject: Re: [PATCH 02/31] nds32: Kernel booting and initialization
To:     Greentime Hu <green.hu@gmail.com>
Cc:     greentime@andestech.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>,
        netdev <netdev@vger.kernel.org>,
        Vincent Chen <vincentc@andestech.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Nov 7, 2017 at 11:54 PM, Greentime Hu <green.hu@gmail.com> wrote:
> From: Greentime Hu <greentime@andestech.com>
>

Commit message needed.

> Signed-off-by: Vincent Chen <vincentc@andestech.com>
> Signed-off-by: Greentime Hu <greentime@andestech.com>
> ---

> +       /* it could update max_pfn */
> +       if (max_pfn - ram_start_pfn <= MAXMEM_PFN)
> +               max_low_pfn = max_pfn;
> +       else {
> +               max_low_pfn = MAXMEM_PFN + ram_start_pfn;
> +#ifndef CONFIG_HIGHMEM

Use IS_ENABLED here and other ifdef's if possible.

> +               max_pfn = MAXMEM_PFN + ram_start_pfn;
> +#endif
> +       }


> +static int __init nds32_device_probe(void)
> +{
> +       return of_platform_populate(NULL, NULL, NULL, NULL);
> +}
> +
> +device_initcall(nds32_device_probe);

You can drop this. The core code will call of_platform_populate for you.

From 1583483485147725708@xxx Wed Nov 08 07:52:10 +0000 2017
X-GM-THRID: 1583483485147725708
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread