Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756870AbYAOKJ1 (ORCPT ); Tue, 15 Jan 2008 05:09:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755565AbYAOKIx (ORCPT ); Tue, 15 Jan 2008 05:08:53 -0500 Received: from ns2.suse.de ([195.135.220.15]:45806 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755491AbYAOKIv (ORCPT ); Tue, 15 Jan 2008 05:08:51 -0500 From: Andi Kleen Organization: SUSE Linux Products GmbH, Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg) To: Harvey Harrison Subject: Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr Date: Tue, 15 Jan 2008 11:06:41 +0100 User-Agent: KMail/1.9.6 Cc: linux-kernel@vger.kernel.org, jbeulich@novell.com, mingo@elte.hu, tglx@linutronix.de References: <200801141116.534682000@suse.de> <20080114221645.90C5D14F83@wotan.suse.de> <1200389391.16794.12.camel@brick> In-Reply-To: <1200389391.16794.12.camel@brick> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801151106.41855.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 585 Lines: 17 On Tuesday 15 January 2008 10:29:51 Harvey Harrison wrote: > On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote: > > Instead of open coding the bit accesses uses standard style > > *PageDeferred* macros. > > > > Any reason these couldn't be static inlines in a shared header? The whole usage of that bit is private to the file -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/