Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <93c53d82-2b62-bb74-c472-8923bb2893aa@redhat.com>
References: <1510192934-5369-1-git-send-email-wanpeng.li@hotmail.com>
 <1510192934-5369-3-git-send-email-wanpeng.li@hotmail.com> <e985d61a-18ef-6dce-e058-c45538ffcdff@redhat.com>
 <CANRm+Cy6rC3+avTuzxHMKtgiyJVPpLXJc0v_YxE-T6kF6kYT9w@mail.gmail.com> <93c53d82-2b62-bb74-c472-8923bb2893aa@redhat.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Thu, 9 Nov 2017 19:08:52 +0800
Message-ID: <CANRm+Cyy1stZFpKuan+ZJV4nH-X+tM67Z+UF9ivyu6fgOA30Yg@mail.gmail.com>
Subject: Re: [PATCH RESEND 2/3] KVM: Add paravirt remote TLB flush
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Eduardo Valentin <eduval@amazon.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2017-11-09 19:02 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
> On 09/11/2017 12:01, Wanpeng Li wrote:
>> 2017-11-09 18:48 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>>> On 09/11/2017 03:02, Wanpeng Li wrote:
>>>> @@ -484,6 +511,8 @@ void __init kvm_guest_init(void)
>>>>               pv_time_ops.steal_clock = kvm_steal_clock;
>>>>       }
>>>>
>>>> +     pv_mmu_ops.flush_tlb_others = kvm_flush_tlb_others;
>>>
>>> This needs to be keyed on a new CPUID feature bit.  Eduardo is also
>>
>> Will do.
>>
>>> adding a new "PV_DEDICATED" hint and you might disable PV TLB flush when
>>> PV_DEDICATED is set.
>>
>> Why disable PV TLB flush for PV_DEDICATED(qspinlock)?
>
> PV_DEDICATED says pretty much that it is very unlikely to have a
> preempted vCPU.  Therefore, the cpumask loop is unnecessary.

Thanks for pointing out this. :)

Regards,
Wanpeng Li

From 1583586262404822977@xxx Thu Nov 09 11:05:46 +0000 2017
X-GM-THRID: 1583551558691477552
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread