DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding;
        b=OGs6EAFWmT2vMSLEun76nK4Z2ct0c2I5V5YFQk9i3oxIbUKPrpr2+LkMFusFIMpFFps87eO9tAUHx/LWlcZozrwrGXpbhsgmuvYS1faWxLq+P5+esQRnXa0H4eDAiOCcui4VjNSeYvOV7eGGLmngzdY3dYPXmKDcb7uWuCjC+1U=
Subject: Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page
	flags in change_page_attr
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, jbeulich@novell.com, mingo@elte.hu,
       tglx@linutronix.de
In-Reply-To: <200801151106.41855.ak@suse.de>
References: <200801141116.534682000@suse.de>
	 <20080114221645.90C5D14F83@wotan.suse.de> <1200389391.16794.12.camel@brick>
	 <200801151106.41855.ak@suse.de>
Content-Type: text/plain
Date: Tue, 15 Jan 2008 02:15:02 -0800
Message-Id: <1200392102.16794.26.camel@brick>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 804
Lines: 22

On Tue, 2008-01-15 at 11:06 +0100, Andi Kleen wrote:
> On Tuesday 15 January 2008 10:29:51 Harvey Harrison wrote:
> > On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote:
> > > Instead of open coding the bit accesses uses standard style
> > > *PageDeferred* macros. 
> > > 
> > 
> > Any reason these couldn't be static inlines in a shared header?
> 
> The whole usage of that bit is private to the file

True if pageattr_32|64.c get merged, not one I have looked at yet,
but wouldn't a static inline in the files then be better for the
typechecking?

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/