Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Nov 2017 09:07:24 +0100 (CET)
From:   Miroslav Benes <mbenes@suse.cz>
To:     Josh Poimboeuf <jpoimboe@redhat.com>
cc:     jeyu@kernel.org, jikos@kernel.org, pmladek@suse.com,
        lpechacek@suse.cz, pavel@ucw.cz, live-patching@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] livepatch: force transition process to finish
In-Reply-To: <20171102131318.ovjpygmerxhadhu7@treble>
Message-ID: <alpine.LSU.2.21.1711030907030.31648@pobox.suse.cz>
References: <20171031114853.841-1-mbenes@suse.cz> <20171031114853.841-3-mbenes@suse.cz> <20171102131318.ovjpygmerxhadhu7@treble>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2 Nov 2017, Josh Poimboeuf wrote:

> On Tue, Oct 31, 2017 at 12:48:53PM +0100, Miroslav Benes wrote:
> > If a task sleeps in a set of patched functions uninterruptedly, it could
> > block the whole transition process indefinitely.  Thus it may be useful
> > to clear its TIF_PATCH_PENDING to allow the process to finish.
> 
> The phrase "transition process" (here and in the patch title) confused
> me a little bit, since elsewhere we just call it "transition".

Ok.
 
> > +static ssize_t force_store(struct kobject *kobj, struct kobj_attribute *attr,
> > +			   const char *buf, size_t count)
> > +{
> > +	int ret;
> > +	bool val;
> > +
> > +	/*
> > +	 * klp_mutex lock is not grabbed here intentionally. It is not really
> > +	 * needed. The race window is harmless and grabbing the lock would only
> > +	 * hold the action back.
> > +	 */
> > +	if (!klp_transition_patch)
> > +		return -EINVAL;
> > +
> > +	ret = kstrtobool(buf, &val);
> > +	if (ret)
> > +		return ret;
> > +
> > +	if (val)
> > +		klp_force_transitions();
> 
> The plural "transitions" is inconsistent with the rest of the code,
> which uses it in the singular.  How about klp_force_transition() or
> klp_force()?

klp_force_transition() it is.

Miroslav

From 1582960199189699045@xxx Thu Nov 02 13:14:45 +0000 2017
X-GM-THRID: 1582773873031494647
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread