Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     "H. Nikolaus Schaller" <hns@goldelico.com>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        =?ISO-8859-1?Q?Beno=EEt?= Cousson <bcousson@baylibre.com>,
        Tony Lindgren <tony@atomide.com>,
        Russell King <linux@armlinux.org.uk>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Julia Lawall <Julia.Lawall@lip6.fr>,
        Sean Paul <seanpaul@chromium.org>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org,
        letux-kernel@openphoenux.org, kernel@pyra-handheld.com
Subject: Re: [PATCH 1/4] omapdrm: fix compatible string for td028ttec1
Date:   Thu, 09 Nov 2017 05:33:40 +0200
Message-ID: <2790033.EQlQQc1BPI@avalon>
Organization: Ideas on Board Oy
In-Reply-To: <8678120467a1d0e67d4d882b3f01d58867586653.1510175371.git.hns@goldelico.com>
References: <cover.1510175371.git.hns@goldelico.com> <8678120467a1d0e67d4d882b3f01d58867586653.1510175371.git.hns@goldelico.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Nikolaus,

Thank you for the patch.

On Wednesday, 8 November 2017 23:09:29 EET H. Nikolaus Schaller wrote:
> The vendor name was "toppoly" but other panels and the vendor list
> have defined it as "tpo". So let's fix it in driver and bindings.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
>  .../display/panel/{toppoly,td028ttec1.txt => tpo,td028ttec1.txt} | 4 ++--
> drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c           | 4 ++--
> drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c  | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>  rename
> Documentation/devicetree/bindings/display/panel/{toppoly,td028ttec1.txt =>
> tpo,td028ttec1.txt} (84%)
> 
> diff --git
> a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
> b/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt
> similarity index 84%
> rename from
> Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
> rename to
> Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt index
> 7175dc3740ac..ed34253d9fb1 100644
> --- a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
> +++ b/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt @@
> -2,7 +2,7 @@ Toppoly TD028TTEC1 Panel
>  ========================
> 
>  Required properties:
> -- compatible: "toppoly,td028ttec1"
> +- compatible: "tpo,td028ttec1"
> 
>  Optional properties:
>  - label: a symbolic name for the panel
> @@ -14,7 +14,7 @@ Example
>  -------
> 
>  lcd-panel: td028ttec1@0 {
> -	compatible = "toppoly,td028ttec1";
> +	compatible = "tpo,td028ttec1";
>  	reg = <0>;
>  	spi-max-frequency = <100000>;
>  	spi-cpol;
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
> b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c index
> 0a38a0e8c925..2dab491478c2 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
> @@ -452,7 +452,7 @@ static int td028ttec1_panel_remove(struct spi_device
> *spi) }
> 
>  static const struct of_device_id td028ttec1_of_match[] = {
> -	{ .compatible = "omapdss,toppoly,td028ttec1", },
> +	{ .compatible = "omapdss,tpo,td028ttec1", },

Doesn't this break backward compatibility with existing DT ?

>  	{},
>  };
> 
> @@ -471,7 +471,7 @@ static struct spi_driver td028ttec1_spi_driver = {
> 
>  module_spi_driver(td028ttec1_spi_driver);
> 
> -MODULE_ALIAS("spi:toppoly,td028ttec1");
> +MODULE_ALIAS("spi:tpo,td028ttec1");
>  MODULE_AUTHOR("H. Nikolaus Schaller <hns@goldelico.com>");
>  MODULE_DESCRIPTION("Toppoly TD028TTEC1 panel driver");
>  MODULE_LICENSE("GPL");
> diff --git
> a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
> b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c index
> 57e9e146ff74..39e1754746d2 100644
> --- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
> +++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
> @@ -455,7 +455,7 @@ static int td028ttec1_panel_remove(struct spi_device
> *spi) }
> 
>  static const struct of_device_id td028ttec1_of_match[] = {
> -	{ .compatible = "omapdss,toppoly,td028ttec1", },
> +	{ .compatible = "omapdss,tpo,td028ttec1", },
>  	{},
>  };
> 
> @@ -474,7 +474,7 @@ static struct spi_driver td028ttec1_spi_driver = {
> 
>  module_spi_driver(td028ttec1_spi_driver);
> 
> -MODULE_ALIAS("spi:toppoly,td028ttec1");
> +MODULE_ALIAS("spi:tpo,td028ttec1");
>  MODULE_AUTHOR("H. Nikolaus Schaller <hns@goldelico.com>");
>  MODULE_DESCRIPTION("Toppoly TD028TTEC1 panel driver");
>  MODULE_LICENSE("GPL");


-- 
Regards,

Laurent Pinchart


From 1583533856183528780@xxx Wed Nov 08 21:12:47 +0000 2017
X-GM-THRID: 1583533856183528780
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread