Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171108094705.GK1370@distanz.ch>
References: <cover.1510118606.git.green.hu@gmail.com> <f01f62d9666876052cc37043b605b60355bf54d7.1510118606.git.green.hu@gmail.com>
 <20171108094705.GK1370@distanz.ch>
From:   Greentime Hu <green.hu@gmail.com>
Date:   Thu, 9 Nov 2017 15:19:57 +0800
Message-ID: <CAEbi=3e_Sz_VyE0H_VAFW9rJ98VwNgJe36ayFbQsL0UdQMQ7Mw@mail.gmail.com>
Subject: Re: [PATCH 03/31] nds32: Support early_printk
To:     Tobias Klauser <tklauser@distanz.ch>
Cc:     Greentime <greentime@andestech.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        linux-arch <linux-arch@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        netdev <netdev@vger.kernel.org>, Rick Chen <rick@andestech.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2017-11-08 17:47 GMT+08:00 Tobias Klauser <tklauser@distanz.ch>:
> On 2017-11-08 at 06:54:51 +0100, Greentime Hu <green.hu@gmail.com> wrote:
>> From: Greentime Hu <greentime@andestech.com>
>>
>> Signed-off-by: Rick Chen <rick@andestech.com>
>> Signed-off-by: Greentime Hu <greentime@andestech.com>
>> ---
>>  arch/nds32/kernel/early_printk.c |  124 ++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 124 insertions(+)
>>  create mode 100644 arch/nds32/kernel/early_printk.c
>>
>> diff --git a/arch/nds32/kernel/early_printk.c b/arch/nds32/kernel/early_printk.c
>> new file mode 100644
>> index 0000000..269c3cd
>> --- /dev/null
>> +++ b/arch/nds32/kernel/early_printk.c
>
> Could be implemented using earlycon (the 8250 drivers already supports
> it) instead of duplicating functionality in arch/nds32?  See e.g. the
> nios2 port for how this could be done, specifically commit e118c3fec9c0
> ("nios2: remove custom early console implementation").

Thanks.
I will try to use earlycon in the next version patch.
I will remove this patch if earlycon is able to be used in nds32.

From 1583490813232785189@xxx Wed Nov 08 09:48:38 +0000 2017
X-GM-THRID: 1583483512506029402
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread