Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH x86/urgent] bpf: emulate push insns for uprobe on x86
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     David Miller <davem@davemloft.net>, <mingo@kernel.org>,
        <oleg@redhat.com>, <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        <netdev@vger.kernel.org>, <ast@fb.com>, <kernel-team@fb.com>
References: <20171108213712.1232793-1-yhs@fb.com>
 <20171109.090647.824552877953564084.davem@davemloft.net>
 <526920a7-0329-cc2b-0cae-1af221a48aee@fb.com>
 <alpine.DEB.2.20.1711090749190.1962@nanos>
From:   Yonghong Song <yhs@fb.com>
Message-ID: <f3babdc6-1018-7c48-86d6-b6b177885310@fb.com>
Date:   Wed, 8 Nov 2017 23:57:44 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1711090749190.1962@nanos>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2017 07:57:50.4200 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 868efca6-0ad1-4fd3-cea6-08d5274794fa
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1839
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-09_01:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/8/17 10:53 PM, Thomas Gleixner wrote:
> On Wed, 8 Nov 2017, Yonghong Song wrote:
>> On 11/8/17 4:06 PM, David Miller wrote:
>>> From: Yonghong Song <yhs@fb.com>
>>> Date: Wed, 8 Nov 2017 13:37:12 -0800
>>>
>>>> Uprobe is a tracing mechanism for userspace programs.
>>>> Typical uprobe will incur overhead of two traps.
>>>> First trap is caused by replaced trap insn, and
>>>> the second trap is to execute the original displaced
>>>> insn in user space.
>>>    ...
>>>
>>> I don't understand how this is bpf related, and if it is you don't
>>> explain it well in the commit message.
>>
>> Right. This is not related to bpf. Will remove the "bpf" from the subject line
>> in the next revision.
> 
> The proper subject is something like:
> 
>      [PATCH] uprobes/x86: .......

Thanks, Thomas,

I will fix the subject etc. Previously, I added x86/urgent as the branch
I did my test on top of it (similar to net-next). I will add that 
information in the comments and re-submit.

> 
> which you can figure out by looking at the subsystem prefixes via
> 
>      git log arch/x86/kernel/uprobes.c
> 
> Note, that it says [PATCH} and nothing else. That patch is a nice
> performance improvement, but certainly not x86/urgent material. x86/urgent
> is for bug and regression fixes.
> 
> Thanks,
> 
> 	tglx
> 

From 1583570460990424579@xxx Thu Nov 09 06:54:36 +0000 2017
X-GM-THRID: 1583535533505282119
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread