Date: Tue, 15 Jan 2008 14:54:19 +0100
From: Sam Ravnborg <sam@ravnborg.org>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Mikael Starvik <mikael.starvik@axis.com>, linux-kernel@vger.kernel.org,
       Yuusei KUWANA <kuwana@nyanyan.to>
Subject: Re: [PATCH] CRIS v10: vmlinux.lds.S Fix kernel oops on boot and use common defines
Message-ID: <20080115135419.GA17685@uranus.ravnborg.org>
References: <20080115133624.GD3912@axis.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080115133624.GD3912@axis.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1199
Lines: 32

On Tue, Jan 15, 2008 at 02:36:24PM +0100, Jesper Nilsson wrote:
> - Move alignment to page size of init data outside ifdef for BLK_DEV_INITRD.
>   The reservation up to page size of memory after init data was previously
>   not done if BLK_DEV_INITRD was undefined.
>   This caused a kernel oops when init memory pages were freed after startup,
>   data placed in the same page as the last init memory would also be freed
>   and reused, with disastrous results.
> 
> - Use macros for initcalls and .text sections.
> 
> - Replace hardcoded page size constant with PAGE_SIZE define.
> 
> - Change include/asm-cris/page.h to use the _AC macro to instead
>   of testing __ASSEMBLY__.

Looks good.

What about applying the same fixes/changes to v32?

It would btw. be nice to move the vmlinux.lds.S files to
arch/cris/kernel/.
Se how x86 handle build for two different bit sizes.

If this is done then cris is less awkward compared
to the other archs.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/